Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python 3.5 support in eth module #1391

Closed
carver opened this issue Oct 12, 2018 · 5 comments
Closed

Drop python 3.5 support in eth module #1391

carver opened this issue Oct 12, 2018 · 5 comments

Comments

@carver
Copy link
Contributor

carver commented Oct 12, 2018

What is wrong?

Python 3.6 was released nearly 2 years ago. trinity is alpha software, which won't be stable for another good while. Python 3.5 doesn't support some sweet syntax like f-strings, native typing annotations, etc.

How can it be fixed

Let's drop py3.5 support from the eth module, and require >=3.6.

Objections?

@carver carver added this to the Hedy Lamarr (Trinity Release) milestone Oct 12, 2018
@pipermerriam
Copy link
Member

I believe we are held up by: Web3.py -> eth-tester -> py-evm eth module

@carver
Copy link
Contributor Author

carver commented Oct 12, 2018

#1390 (comment)

Good point about web3.

Potentially web3 v4 can freeze py-evm at the current version, and updates to py-evm will only be available in web3 v5. (which I expect to be py3.6+)

@pipermerriam
Copy link
Member

Our much ignored mailing list and /r/ethereum might be good places to solicit feedback (and prepare people).

@jacqueswww
Copy link
Contributor

Good stuff! This is great from a vyper perspective - as vyper also requires 3.6.

@carver carver removed this from the Hedy Lamarr (Trinity Release) milestone Dec 13, 2018
@pacrob
Copy link
Collaborator

pacrob commented Dec 20, 2023

dropped in #1785

@pacrob pacrob closed this as completed Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants