Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate utility functions from eth.tools.fixtures.normalization #1407

Closed
pipermerriam opened this issue Oct 17, 2018 · 2 comments
Closed

Remove duplicate utility functions from eth.tools.fixtures.normalization #1407

pipermerriam opened this issue Oct 17, 2018 · 2 comments
Labels
Good First Issue

Comments

@pipermerriam
Copy link
Member

What is wrong?

from: #1396 (review)

There are duplicates of some of the functions in:

  • eth.tools._utils.normalization
  • eth.tools.fixtures.normalization

Specifically the normalize_int but there may be others.

How can it be fixed

Audit these two modules for duplicate functions and remove the duplicates. In the case of normalize_int, the _utils one should be kept. Use your best judgement on any others that are found.
@isaacelee
Copy link

I'm going to look in to this, shouldn't be too difficult.

@isaacelee isaacelee mentioned this issue Oct 26, 2018
Closed
@glaksmono
Copy link
Contributor

@isaacelee are you still working on this? Otherwise I'm considering to take a stab on it

@glaksmono glaksmono mentioned this issue Nov 20, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed the duplicate functions
4 participants
@glaksmono @cburgdorf @pipermerriam @isaacelee