Fix unregistering events for solidity module #2640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yann300
changed the title
LianaHus
approved these changes
Mar 13, 2020
yann300
force-pushed
the
fixUnregisteringToEvent
branch
from
cfa3bd0
to
1d74a5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a potential bug as now
onDeactivationis called by the plugin manager.it is not possible to call ´this.compiler.event.unregister('loadingCompiler')´
or
this.fileManager.events.removeListener('startingCompilation').The callback function needs to be specified.
e.g `this.fileManager.events.removeListener('startingCompilation', functionThatNeedToBeUnLinnked)``
So this PR keep track of all the callback used by event handlers so they can be correctly unlinked.