Added Metadata Contract Name To Success Modal #2677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LianaHus
reviewed
Mar 27, 2020
src/app/tabs/compile-tab.js
Outdated
| @@ -348,7 +349,7 @@ class CompileTab extends ViewPlugin { | |||
| var result = yo`<div>${uploaded.map((value) => { | |||
| return yo`<div><b>${value.filename}</b> : <pre>${value.output.url}</pre></div>` | |||
| })}</div>` | |||
| modalDialogCustom.alert(yo`<span>Metadata published successfully.<br> <pre>${result}</pre> </span>`) | |||
| modalDialogCustom.alert(`Published ${contract.name} Metadata`, yo`<span>Metadata of ${contract.name.toLowerCase()} contract was published successfully.<br> <pre>${result}</pre> </span>`) | |||
There was a problem hiding this comment.
could you please add quotes around the 'contract.name'?
LianaHus
reviewed
Mar 31, 2020
src/app/tabs/compile-tab.js
Outdated
| @@ -332,7 +332,7 @@ class CompileTab extends ViewPlugin { | |||
| var result = yo`<div>${uploaded.map((value) => { | |||
| return yo`<div><b>${value.filename}</b> : <pre>${value.output.url}</pre></div>` | |||
| })}</div>` | |||
| modalDialogCustom.alert(`Published ${contract.name} Metadata`, yo`<span>Metadata of ${contract.name.toLowerCase()} contract was published successfully.<br> <pre>${result}</pre> </span>`) | |||
| modalDialogCustom.alert(`Published "${contract.name}" Metadata`, yo`<span>Metadata of ${contract.name.toLowerCase()} was published successfully.<br> <pre>${result}</pre> </span>`) | |||
There was a problem hiding this comment.
I'm sorry but could you please also add ""s to contract name in the text?
Metadata of "ballot" was.....
ioedeveloper
force-pushed
the
publish-metadata
branch
from
0a95392
to
393695f
Compare
LianaHus
approved these changes
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed https://github.com/ethereum/remix-ide/issues/2549