Load wasm builds if available #2828
Conversation
LianaHus
force-pushed
the
wasmBuilds
branch
2 times, most recently
from
31bf2d1
to
d6ae32a
Compare
LianaHus
changed the title
| @@ -25,7 +24,8 @@ class CompilerContainer { | |||
| allversions: null, | |||
| selectedVersion: null, | |||
| defaultVersion: 'soljson-v0.6.6+commit.6c089d02.js', // this default version is defined: in makeMockCompiler (for browser test) and in package.json (downloadsolc_root) for the builtin compiler | |||
| baseurl: 'https://solc-bin.ethereum.org/bin' | |||
| baseURLWasm: baseURLWasm, | |||
There was a problem hiding this comment.
you don't need to make it a data property, you are importing it
| async fetchAllVersion (callback) { | ||
| let allVersions, selectedVersion, allVersionsWasm | ||
| // fetch normal builds | ||
| const binRes = await promisedMiniXhr(`${this.data.baseURLBin}/list.json`) |
There was a problem hiding this comment.
const binRes = await promisedMiniXhr(${baseURLBin}/list.json) instead?
|
do we need new e2e tests or is this already tested? |
LianaHus
force-pushed
the
wasmBuilds
branch
2 times, most recently
from
08ebeaa
to
de620d0
Compare
I've added some. Please take a look at diff, Feel free to share more ideas on how to test it if you have any. |
| browser | ||
| .clickLaunchIcon('solidity') | ||
| .setSolidityCompilerVersion(version) | ||
| .waitForElementPresent('*[data-id="compiledErrors"]') |
There was a problem hiding this comment.
is everything recompiled after version is changed?
There was a problem hiding this comment.
any ideas on how I can check that besides waiting ?
There was a problem hiding this comment.
if you run it locally you'll see it
There was a problem hiding this comment.
yes but is there a way to assert it?
package.json
Outdated
| @@ -81,6 +81,7 @@ | |||
| "dependencies": { | |||
| "@remixproject/engine": "^0.2.3", | |||
| "http-server": "^0.11.1", | |||
| "selenium": "^2.20.0", | |||
There was a problem hiding this comment.
not sure you need that here
There was a problem hiding this comment.
Something went wrong while I was trying to test locally :). Will remove this. Thanks
LianaHus
force-pushed
the
wasmBuilds
branch
2 times, most recently
from
0ff6e1a
to
164a50d
Compare
fix https://github.com/ethereum/remix-ide/issues/2822