-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undo change from SVG to WEBP #645
Comments
@fulldecent thanks for keeping a positive discussion on github. We all try to do our best to improve devX. webp is a great format recommended to be use on the web. As it happens, Safari and IE don't support webp, and we didn't realized that as nobody in the team are using neither of them. The right working plan would be to provide a fallback to svg or png for browser that doesn't support webp. Like that users using other browser than Safari or IE can enjoy the benefice of webp images. |
In general, SVG vector graphics are superior to bitmap graphics. They look great on every device/screen/resolution, they minimize file size and they are losslessly editable. The only times to avoid SVG are:
These are the reasons I recommend to revert to using SVG. Human/voice note: The people mentioned above are good. And the commits were well intentioned. And they even made an improvement (refactoring image from inline to separate file). I am concerned only with the negative impact of the commit mentioned above. |
@GrandSchtroumpf the article you cite https://web.dev/serve-images-webp/ does not match your summary "webp is a great format recommended to be use on the web" in this context. That article (correctly) only recommends:
It does not recommend replacing SVGs with WebPs. @LianaHus likewise, the article you cite https://www.macrumors.com/2020/06/22/webp-safari-14/ only compares:
Likewise, no recommendation is made for replacing SVGs to be WebPs. |
@fulldecent your problem should be solved now in remix-alpha can you confirm? |
Looks good in Safari. We do have SVGs of all of the icons except unitTesting.webp. Proof:
Here is the original artwork for localPlugin in SVG format 040876c Attached above ^^ There is no security issue of using SVG files as images that are hosted in this repository. Or if there is a security issue, then it is surely less that that of hosting HTML in this repository. |
These commits are bad:
7c539d8
f089853
da59354
From @LianaHus @ioedeveloper
They removed vector images in a format that works with all browsers and replaced it with a raster format that only works with some browsers.
Here is how remix currently loads on macOS Big Sur / Safari for me:
Work plan
The text was updated successfully, but these errors were encountered: