Unwanted Event Listener removal for Docgen #3601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Aniket-Engg
reviewed
Apr 6, 2023
apps/doc-gen/src/app/App.tsx
Outdated
| @@ -29,7 +29,7 @@ const App = () => { | |||
|
|
|||
| return ( | |||
| <div className="p-3"> | |||
| <h5 className="h-5 mb-3">Compile a solidity contract in order to build documentation as markdown or right click on a contract and click on "Generate Documentation".</h5> | |||
| <h5 className="h-5 mb-3">Compile a Solidity contract and generate its documentation as Markdown. (Shortcut: right-click on a contract in the File Explorer and select "Generate Docs" from the context menu.).</h5> | |||
There was a problem hiding this comment.
details you have added is not a shortcut
There was a problem hiding this comment.
If you check the dev-ux channel in discord, you will understand why the wording has changed.
Aniket-Engg
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the blanket removal of the 'compilationFinished' event listener. Not removing this causes the documentation generation to never actually happen.