warn the user about evm version #3629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
LianaHus
reviewed
Apr 18, 2023
| @@ -5,6 +5,7 @@ | |||
| "udapp.value": "Value", | |||
| "udapp.contract": "Contract", | |||
| "udapp.compiledBy": "Compiled by {compilerName}", | |||
| "udapp.warningEvmVersion": "Please make sure that the current network is following the evm version: {evmVersion}. Otherwise any deployment will fail.", | |||
There was a problem hiding this comment.
i think you don't need "that" here
Aniket-Engg
force-pushed
the
warning_evm_version
branch
from
a6a5151
to
b354e07
Compare
yann300
force-pushed
the
warning_evm_version
branch
from
b354e07
to
d7df1a5
Compare
| could you please remove this line? to align those badges |
|
and I don't know why the mouse pointer is not working on hover for only this badge. |
joeizang
reviewed
Jun 7, 2023
yes, but one need to make sure the right evm version is selected in "run and deploy"
Compilation can also come from other sources (hardhat, ..) |
yann300
force-pushed
the
warning_evm_version
branch
from
84bf377
to
458bcad
Compare
LianaHus
approved these changes
Jun 7, 2023
yann300
force-pushed
the
warning_evm_version
branch
from
458bcad
to
984be73
Compare
yann300
force-pushed
the
warning_evm_version
branch
from
984be73
to
0616614
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3628