eip3860 #3650
Merged
eip3860 #3650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| @@ -27,7 +27,7 @@ | |||
| "udapp.contractOptionsTitle3": "选择并编译 *.sol 文件以部署或访问合约。", | |||
| "udapp.contractOptionsTitle4": "当有编译的 .sol 文件时，选择 {br} 合约进行部署或与 AtAddress 一起使用。", | |||
| "udapp.checkSumWarning": "您似乎没有使用 checksumed address 。{br} checksumed address 是包含大写字母的地址，如 {a} 中所指定。{br} checksumed address 旨在帮助防止用户将交易发送到错误地址。", | |||
| "udapp.isOverSizePrompt": "合约创建初始化返回长度超过24576字节的数据。部署可能会失败。 {br}更多信息：{a}", | |||
| "udapp.isOverSizePromptEip170": "合约创建初始化返回长度超过24576字节的数据。部署可能会失败。 {br}更多信息：{a}", | |||
There was a problem hiding this comment.
You forgot to add translation for udapp.isOverSizePromptEip3860
There was a problem hiding this comment.
I've added the "translation" label, for @ryestew.
| const encodedParams = await txFormat.encodeParams(args, txHelper.getConstructorInterface(contract.object.abi)) | ||
| const bytecode = contract.object.evm.bytecode.object + (encodedParams as any).dataHex | ||
| // https://eips.ethereum.org/EIPS/eip-3860 | ||
| const initCodeOversize = (bytecode && bytecode.length / 2 > 2 * 24576) |
There was a problem hiding this comment.
Can you separate the condition with brackets to make it easier to read?
| } | ||
| { | ||
| values.overSizeEip3860 && <div> | ||
| <FormattedMessage id='udapp.isOverSizePromptEip3860' values={{ br: <br />, a: <a href="https://eips.ethereum.org/EIPS/eip-3860" target="_blank" rel="noreferrer">eip-170</a> }} /> |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Aniket-Engg
force-pushed
the
fix_contract_size_max
branch
from
afdee6a
to
8c03a97
Compare
ioedeveloper
approved these changes
Apr 28, 2023
Aniket-Engg
force-pushed
the
fix_contract_size_max
branch
2 times, most recently
from
3ebb999
to
677d463
Compare
yann300
force-pushed
the
fix_contract_size_max
branch
2 times, most recently
from
425ed12
to
7a0e9b7
Compare
Aniket-Engg
force-pushed
the
fix_contract_size_max
branch
from
7a0e9b7
to
351c8c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3640
in order to test eip170, compile and deploy https://github.com/yann300/remix-reward (without optimization enabled).
in order to test eip3860, update remix reward to have a unique param for the constructor:
bytes32compile, copy the bytecode from (the solidity tab), go to udapp, deploy remix reward using the previously copied data.(note that the copied bytecode can be anything it is really just to have enough data to reach max code size).