update verify script to support proxy contract verification #3771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Aniket-Engg
force-pushed
the
scriptUpdate2
branch
from
c9617ae
to
b1352ef
Compare
yann300
reviewed
Jun 8, 2023
| * @returns {{ guid, status, message, succeed }} verification result | ||
| */ | ||
| export const verify = async (apikey: string, contractAddress: string, contractArguments: string, contractName: string, contractFile: string, chainRef: number | string) => { | ||
| export const verify = async (apikey: string, contractAddress: string, contractArguments: string, contractName: string, contractFile: string, chainRef: number | string, isProxyContract: boolean, expectedImplAddress: string) => { |
There was a problem hiding this comment.
these should be merked as optional parameters.
There was a problem hiding this comment.
Although it is mentioned in comment that arguments are required in case of proxy contract
yann300
reviewed
Jun 8, 2023
| const compilationResultParam = await remix.call('compilerArtefacts' as any, 'getCompilerAbstract', contractFile) | ||
| console.log('verifying.. ' + contractName) | ||
| // update apiKey and chainRef to verify contract on multiple networks | ||
| return await remix.call('etherscan' as any, 'verify', apikey, contractAddress, contractArguments, contractName, compilationResultParam, chainRef) | ||
| return await remix.call('etherscan' as any, 'verify', apikey, contractAddress, contractArguments, contractName, compilationResultParam, chainRef, isProxyContract, expectedImplAddress) |
There was a problem hiding this comment.
does etherscan' as any, 'verify' as isProxyContract, expectedImplAddress? it doesn't look like
There was a problem hiding this comment.
same for chainRef actually.
There was a problem hiding this comment.
please check the receiptStatus call too.
There was a problem hiding this comment.
updated in latest commits
Aniket-Engg
force-pushed
the
scriptUpdate2
branch
2 times, most recently
from
d53a140
to
ff8033c
Compare
yann300
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3750 (comment)
closes #3597