Static Analyzers Run Button Fix #3876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Aniket-Engg
reviewed
Jun 30, 2023
This is a different pr @Aniket-Engg. The pr with improvements will be ready soon |
LianaHus
requested changes
Jul 5, 2023
| } | ||
| } | ||
|
|
||
| function runTests (browser: NightwatchBrowser) { | ||
| function runTests(browser: NightwatchBrowser) { |
| ) | ||
| }) | ||
| } | ||
|
|
||
| function listSelectorContains (textsToFind: string[], selector: string, browser: NightwatchBrowser) { | ||
| function listSelectorContains(textsToFind: string[], selector: string, browser: NightwatchBrowser) { |
| <span className="pl-3 pr-4"> | ||
| {buttonText} | ||
| </span> | ||
| </button> |
|
how it was fixed exactly? |
In that case, can you update PR desc explaining the purpose of this PR? Just to add, merging this PR will close that issue, so I believe everything in that issue should fixed by this PR |
LianaHus
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3839