quick fixes in editor #3928
Merged
quick fixes in editor #3928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Aniket-Engg
force-pushed
the
quickfixes
branch
2 times, most recently
from
9c409ff
to
70cf359
Compare
LianaHus
reviewed
Jul 21, 2023
| import { default as fixes } from "./quickfixes" | ||
|
|
||
| export class RemixCodeActionProvider implements monaco.languages.CodeActionProvider { | ||
| props: EditorUIProps |
There was a problem hiding this comment.
Please use one space as a tab
There was a problem hiding this comment.
the default for TS is 4 spaces
There was a problem hiding this comment.
#3939 sets all to 2 spaces. 1 is not best practice.
There was a problem hiding this comment.
As linting is being fixed in different PR, can you review again? @LianaHus
bunsenstraat
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3927
This PR introduces QuickFixes for:
More quick fixes will be added in upcoming PRs