Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sol2uml Theme Reaction Refactor #3947

Merged
merged 4 commits into from
Jul 31, 2023
Merged

Sol2uml Theme Reaction Refactor #3947

merged 4 commits into from
Jul 31, 2023

Conversation

joeizang
Copy link
Collaborator

fixes #3832

@joeizang joeizang self-assigned this Jul 25, 2023
@netlify
Copy link

netlify bot commented Jul 25, 2023

Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit 34d05b8
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/64bffb0ec838fe00086a1b2c
😎 Deploy Preview https://deploy-preview-3947--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joeizang joeizang added the ready-to-review PR ready to review label Jul 25, 2023
@joeizang joeizang requested a review from LianaHus July 25, 2023 23:54
export type ThemeSummary = { name: string, quality: 'light' | 'dark', url: string, backgroundColor: string, textColor?: string,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could use intersection types?

export type ThemeQualityType = { name: string, quality: 'light' | 'dark', url: string }
export type ThemeSummary = ThemeQualityType & {
  backgroundColor: string,
  textColor?: string,
  shapeColor?: string,
  fillColor?: string,
}

@joeizang joeizang requested review from Aniket-Engg and removed request for LianaHus July 28, 2023 10:21
@joeizang joeizang merged commit 576f557 into master Jul 31, 2023
7 checks passed
@joeizang joeizang deleted the sol2uml-style-upgrades branch July 31, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-review PR ready to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sol2Uml styling improvements
3 participants