Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style of ask gpt and infinit loop and other issues fix #4080

Merged
merged 5 commits into from
Sep 22, 2023
Merged

Conversation

LianaHus
Copy link
Collaborator

@LianaHus LianaHus commented Sep 21, 2023

  • fixing the issue of the second click on "ask gpt"
  • corrected the number of iterations in the timer to use the lengths of the message
  • removed the plugin from the public list
  • style improvements
  • scroll terminal to bottom after each line (improvement in typewriter)

@netlify
Copy link

netlify bot commented Sep 21, 2023

Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit b545dc4
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/650d52fe19268c00092f19cb
😎 Deploy Preview https://deploy-preview-4080--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@LianaHus LianaHus changed the title style of ask gpt and infinit loop error fix style of ask gpt and infinit loop and other issues fix Sep 21, 2023
@LianaHus
Copy link
Collaborator Author

An open question: Do we need to track the usage in matomo. @yann300 @Aniket-Engg

Copy link
Collaborator

@Aniket-Engg Aniket-Engg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -76,6 +78,7 @@ export const Renderer = ({message, opt = {}, plugin}: RendererProps) => {
explain why the error occurred and how to fix it.
`
await plugin.call('openaigpt', 'message', message)
_paq.push(['trackEvent', 'GPTSupport', 'askGPT'])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the places, we use 4 fields for this

@Aniket-Engg Aniket-Engg merged commit a692e95 into master Sep 22, 2023
32 checks passed
@Aniket-Engg Aniket-Engg deleted the askg branch September 22, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants