-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile details update #4167
Compile details update #4167
Conversation
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
f86145f
to
6cb5de9
Compare
@@ -13,6 +14,10 @@ export interface RemixUiCompileDetailsProps { | |||
saveAs: any | |||
} | |||
|
|||
export type ContractPropertyName = 'compilerInput' | 'name' | 'metadata' | 'bytecode' | 'abi' | 'storageLayout' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this type is already define below, we should have one declaration. I know this add a dependency, but that's probably better than duplicating the types.
@@ -1,6 +1,8 @@ | |||
import { CopyToClipboard } from '@remix-ui/clipboard' | |||
import { CustomTooltip } from '@remix-ui/helper' | |||
import { TreeView, TreeViewItem } from '@remix-ui/tree-view' | |||
// eslint-disable-next-line @nrwl/nx/enforce-module-boundaries | |||
import { ContractPropertyName } from 'libs/remix-ui/solidity-compiler/src/lib/types' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check but I think this isn't the right to write this import. You hae to use the module name (solidity-compiler
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. Its done.
1e96107
to
695d882
Compare
No description provided.