-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consider remappings while compilation #4229
Conversation
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
const sources = { [target]: { content } } | ||
this.event.emit('removeAnnotations') | ||
this.event.emit('startingCompilation') | ||
if(!this.useFileConfiguration && await this.api.fileExists('remappings.txt')) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
even if the fileConfiguration is used, maybe still relevant to useremappings.txt
. what's the behavior in foundry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean in foundry who has the priority, remapping.txt or the compileConfig, or is this a merge of both?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Foundry picks the remappings from remappings.txt and foundry.toml both. CompilerConfig is specific to Remix
mappings will be fetched from remapping.txt file