Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugger UI Refactor (React Library) #453

Merged
merged 63 commits into from
Nov 2, 2020
Merged

Debugger UI Refactor (React Library) #453

merged 63 commits into from
Nov 2, 2020

Conversation

ioedeveloper
Copy link
Member

@ioedeveloper ioedeveloper commented Sep 29, 2020

Closes #399

currentValue: ''
})

useEffect(() => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each time the slider is moved, line 9 get hit 1 time and line 13 2 times.
even if if (value === state.currentValue) return helps, that may be useful to check if that may cause performance issue in the stack.

@@ -0,0 +1,166 @@
import React, { useState, useRef, useEffect } from 'react'
import { TreeView, TreeViewItem } from '@remix-ui/tree-view'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error is thrown while unfolding an item from the treeview.
Also the way it is formmatted doesn't seem to be accurate
Screenshot from 2020-10-08 11-47-00

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ that seems to be fixed

@yann300
Copy link
Contributor

yann300 commented Oct 28, 2020

debugging test.set(12) (see bottom) gives a wrong state when being inside the test2.set(12) the value p should be 34 but it displays 8

contract test {
    uint p;
    test2 t;
    constructor () public {
        t = new test2();
        t.set(34);
    }
    
    function set(uint _p) public {
        p = _p;
        t.set(12);
    }
}

contract test2 {
    uint p;
    function set(uint _p) public {
        p = _p;
    }
}

@yann300
Copy link
Contributor

yann300 commented Oct 28, 2020

^ please scratch that... the issue exists in remix-alpha already

@@ -0,0 +1,15 @@
import React from 'react'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems not use in this PR, is this still needed to keep it?

@yann300 yann300 self-requested a review October 30, 2020 13:42
@yann300 yann300 merged commit 33a1326 into master Nov 2, 2020
@ioedeveloper ioedeveloper added this to the Move to React App milestone Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debugger: make it a plugin
2 participants