-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debugger UI Refactor (React Library) #453
Conversation
currentValue: '' | ||
}) | ||
|
||
useEffect(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each time the slider is moved, line 9 get hit 1 time and line 13 2 times.
even if if (value === state.currentValue) return
helps, that may be useful to check if that may cause performance issue in the stack.
@@ -0,0 +1,166 @@ | |||
import React, { useState, useRef, useEffect } from 'react' | |||
import { TreeView, TreeViewItem } from '@remix-ui/tree-view' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ that seems to be fixed
c05b100
to
9f0ea71
Compare
9f0ea71
to
1904a51
Compare
debugging
|
c2ef163
to
a45f79b
Compare
^ please scratch that... the issue exists in remix-alpha already |
@@ -0,0 +1,15 @@ | |||
import React from 'react' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems not use in this PR, is this still needed to keep it?
This reverts commit 86b61a4.
Closes #399