Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vyper improvement patches. #4645

Merged
merged 6 commits into from
Apr 8, 2024
Merged

Vyper improvement patches. #4645

merged 6 commits into from
Apr 8, 2024

Conversation

joeizang
Copy link
Collaborator

@joeizang joeizang commented Mar 18, 2024

address #4537 issues including:

  • spinner for compile button like in Sol plugin
  • Fix badge behaviour to match solidity compiler

@joeizang joeizang added the WIP label Mar 18, 2024
@joeizang joeizang added this to the Milestone - 03/2024 milestone Mar 18, 2024
@joeizang joeizang self-assigned this Mar 18, 2024
Copy link

netlify bot commented Mar 18, 2024

Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit b270b77
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/6613ae2b9ecb0d0008592d9b
😎 Deploy Preview https://deploy-preview-4645--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joeizang joeizang force-pushed the vyper-patch-005 branch 4 times, most recently from f155024 to f341e73 Compare March 22, 2024 08:22
@joeizang joeizang added ready-to-review PR ready to review and removed WIP labels Mar 25, 2024
@joeizang joeizang requested review from Aniket-Engg and removed request for LianaHus March 26, 2024 13:40
Copy link
Collaborator

@ryestew ryestew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The badge update is for the icon panel right? But I don't see any change there - although it does look fine. The spinner change is fine.

@joeizang joeizang requested a review from ryestew April 3, 2024 22:12
@ryestew
Copy link
Collaborator

ryestew commented Apr 4, 2024

The change in this PR is awareness of when a different file is selected than the one that was compiled, it resets the compilation state.
The next change might be to enhance handling the state of vyper compilation sessions, basically bringing more of that state to the ide itself and not rely on the docker container after it sends a compile result.

@ryestew
Copy link
Collaborator

ryestew commented Apr 4, 2024

OK - this PR works - but it is leaving out 1 thing:
When switching between vyper files - if 1 has a compiler error and you switch to another file, the error badge on the icons panel doesn't clear - so the uncompiled file shows the error. A successful compilation will clear this error - but it should be removed when another file has the focus.

@joeizang
Copy link
Collaborator Author

joeizang commented Apr 4, 2024

or. A successful compilation will clear this error - but it should be removed when another file has the focus.

Ok. Can we merge this PR so I make any other changes in another PR?

@joeizang joeizang merged commit deb495f into master Apr 8, 2024
32 checks passed
@joeizang joeizang deleted the vyper-patch-005 branch April 8, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-review PR ready to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants