Add Multiselect dragdrop Feature #4767
Conversation
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
joeizang
force-pushed
the
multiselect-dragdrop
branch
from
3c352fb
to
e2302dd
Compare
|
After releasing in a drop zone, the modal doesn't sometimes show the right files name. |
yann300
force-pushed
the
multiselect-dragdrop
branch
17 times, most recently
from
8bd4498
to
b95c21a
Compare
joeizang
force-pushed
the
multiselect-dragdrop
branch
2 times, most recently
from
c2eb8bd
to
7eb6ad6
Compare
yann300
force-pushed
the
multiselect-dragdrop
branch
2 times, most recently
from
7eb6ad6
to
c57796b
Compare
joeizang
force-pushed
the
multiselect-dragdrop
branch
from
c2df3f7
to
8cc465d
Compare
|
in the file_explorer_multiselect.test.ts file, all tests pass on google chrome but one test, Should drag and drop multiple files in file explorer to tests folder #group1, fails on firefox. Can you look at this test @yann300 ? |
| @@ -69,3 +69,7 @@ ul { | |||
| .remixui_icons:hover { | |||
| color: var(--text); | |||
| } | |||
|
|
|||
| .remixui_selected { | |||
There was a problem hiding this comment.
right. It's actually being used just it doesn't have any css properties in it. Its used in flattree.tsx and getEventTarget.ts
| @@ -116,6 +124,12 @@ export const FlatTree = (props: FlatTreeProps) => { | |||
|
|
|||
| const onDragEnd = (event: SyntheticEvent) => { | |||
| setIsDragging(false) | |||
| document.querySelectorAll('li.remixui_selected').forEach(item => { | |||
There was a problem hiding this comment.
Should be improved to use react hooks (useRef, useState, etc).
| * @returns - {DragStructure} Array of selected items | ||
| */ | ||
| export const buildMultiSelectedItemProfiles = (target: { |
No description provided.