Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Debugger Slider Bug #479

Merged
merged 15 commits into from
Oct 21, 2020
Merged

Fix Debugger Slider Bug #479

merged 15 commits into from
Oct 21, 2020

Conversation

ioedeveloper
Copy link
Member

Fixed #253

@ioedeveloper ioedeveloper changed the title Slider bug Fix Debugger Slider Bug Oct 13, 2020
@ioedeveloper ioedeveloper force-pushed the slider-bug branch 2 times, most recently from 683e6ba to e122b97 Compare October 13, 2020 13:02
@yann300
Copy link
Contributor

yann300 commented Oct 14, 2020

I tried with

contract test {
    function t () public {
        uint[] memory array = new uint[](150);
        for (uint k = 0; k < 150; k++) {
            array[k] = k;
        }
    }
}

load more works but it has loaded until 249 although the actual size is 150

@yann300
Copy link
Contributor

yann300 commented Oct 14, 2020

From UX perspektives, that might be good to open the array in a modal... (for a next PR anyway)

@yann300
Copy link
Contributor

yann300 commented Oct 14, 2020

might even be fine to only loads the first 10 or 20 items from the array.. although 100 is fine (just a remark)
Also we should also probably do this for state array.

@yann300
Copy link
Contributor

yann300 commented Oct 14, 2020

Also we should also probably do this for state array.

I suppose not in this PR.

@yann300
Copy link
Contributor

yann300 commented Oct 14, 2020

Should we have e2e for this?
The contract above could fit.

.clickLaunchIcon('udapp')
.waitForElementPresent('*[data-id="deployAndRunClearInstances"]')
.click('*[data-id="deployAndRunClearInstances"]')
.waitForElementPresent('*[title="Deploy - transact (not payable)"]')
Copy link
Contributor

@yann300 yann300 Oct 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if possible that'd better to use the commands. i.e something like

.selectContract('test')
    .createContract('')
    .clickInstance(2)
    .clickFunction('test1 - transact (not payable)', {types: 'bytes userData', values: '0x000000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000015b38da6a701c568545dcfcb03fcb875f56beddc4'})
    

@yann300 yann300 merged commit 8f4f911 into master Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remix IDE hangs when using slider in debug mode
2 participants