-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Debugger Slider Bug #479
Conversation
683e6ba
to
e122b97
Compare
I tried with
|
From UX perspektives, that might be good to open the array in a modal... (for a next PR anyway) |
might even be fine to only loads the first 10 or 20 items from the array.. although 100 is fine (just a remark) |
I suppose not in this PR. |
Should we have e2e for this? |
.clickLaunchIcon('udapp') | ||
.waitForElementPresent('*[data-id="deployAndRunClearInstances"]') | ||
.click('*[data-id="deployAndRunClearInstances"]') | ||
.waitForElementPresent('*[title="Deploy - transact (not payable)"]') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if possible that'd better to use the commands. i.e something like
.selectContract('test')
.createContract('')
.clickInstance(2)
.clickFunction('test1 - transact (not payable)', {types: 'bytes userData', values: '0x000000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000015b38da6a701c568545dcfcb03fcb875f56beddc4'})
4cd6739
to
9308e19
Compare
This reverts commit 372278d.
9308e19
to
8d7be6d
Compare
Fixed #253