Fix get solidity version for udapp docs #4841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
joeizang
force-pushed
the
get-solidity-version-patch
branch
from
a1be46e
to
38ab598
Compare
Aniket-Engg
reviewed
Jun 10, 2024
| @@ -32,6 +32,22 @@ export function ContractGUI(props: ContractGUIProps) { | |||
| const initializeFields = useRef<Array<HTMLInputElement | null>>([]) | |||
| const basicInputRef = useRef<HTMLInputElement>() | |||
| const intl = useIntl() | |||
| // const [solcVersion, setSolcVersion] = useState({ version: '', canReceive: true }) | |||
There was a problem hiding this comment.
remove commented code
| const getVersion = () => window.location.href.split('=')[5].split('+')[0].split('-')[1] | ||
|
|
||
| // const [solcVersion, setSolcVersion] = useState({ version: '', canReceive: true }) | ||
|
|
There was a problem hiding this comment.
remove commented code
| const getVersion = () => { | ||
| let version = '' | ||
| try { | ||
| version = window.location.href.split('=')[5].split('+')[0].split('-')[1].slice(1) |
There was a problem hiding this comment.
source of issue was this code. When there is no version in URL params, this throws. Better to check if version is available before splitting again
There was a problem hiding this comment.
using null coalescing to make sure that there is a default compiler selected. Hope this is agreeable
joeizang
force-pushed
the
get-solidity-version-patch
branch
from
f686636
to
d6aeece
Compare
joeizang
force-pushed
the
get-solidity-version-patch
branch
from
3a61402
to
b4e6865
Compare
| @@ -299,8 +299,8 @@ export function ContractGUI(props: ContractGUIProps) { | |||
| <div className="d-flex p-0 wrapperElement" onClick={handleActionClick} data-id={buttonOptions.dataId} data-title={buttonOptions.title}> | |||
| <button | |||
| className={`udapp_instanceButton text-nowrap overflow-hidden text-truncate ${props.widthClass} btn btn-sm ${buttonOptions.classList}`} | |||
| data-id={buttonOptions.dataId} | |||
There was a problem hiding this comment.
Are these needed? "firstbullseye" and "bullseye"
ioedeveloper
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4834