Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

status bar fixes #4954

Merged
merged 4 commits into from
Jul 3, 2024
Merged

status bar fixes #4954

merged 4 commits into from
Jul 3, 2024

Conversation

LianaHus
Copy link
Collaborator

@LianaHus LianaHus commented Jul 3, 2024 •
edited
Loading

bg-info to fix theme black
Screenshot from 2024-07-03 11-46-11

@LianaHus LianaHus requested a review from joeizang July 3, 2024 08:23
@netlify Netlify
Copy link

netlify bot commented Jul 3, 2024 •
edited
Loading

✅ Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit fadca7e
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/6685137510a2f90008893588
😎 Deploy Preview https://deploy-preview-4954--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@LianaHus LianaHus requested a review from ryestew July 3, 2024 08:47
@LianaHus LianaHus changed the title updated the colors of black theme to fix the status bar colors status bar fixes Jul 3, 2024
joeizang
joeizang requested changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@joeizang joeizang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I see
image
and this is where the dragbar is:
image

The statusbar looks nice though, I like the color and how contrasty it looks

@LianaHus
Copy link
Collaborator Author

LianaHus commented Jul 3, 2024 via email

joeizang
joeizang approved these changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@joeizang joeizang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LianaHus LianaHus merged commit 88e16ab into master Jul 3, 2024
32 checks passed
@LianaHus LianaHus deleted the themesn branch July 3, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeizang joeizang joeizang approved these changes

@ryestew ryestew Awaiting requested review from ryestew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LianaHus @joeizang