Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Remix copilot status in status bar #5168

Merged
merged 6 commits into from
Sep 10, 2024
Merged

fix Remix copilot status in status bar #5168

merged 6 commits into from
Sep 10, 2024

Conversation

Aniket-Engg
Copy link
Collaborator

@Aniket-Engg Aniket-Engg commented Sep 9, 2024

  • Open Remix and enable Remix co pilot, status is fine
  • Reload Remix IDE
  • When Remix is loaded and no file is selected, status is always disabled. In terminal, it says activated

This is fixed by this PR.

This PR also updates the wording a bit to use enable & disable

Terminal log to show info about Remix co pilot status is removed

Copy link

netlify bot commented Sep 9, 2024

Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit d1b239c
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/66e049db8bd073000883bf81
😎 Deploy Preview https://deploy-preview-5168--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Aniket-Engg Aniket-Engg added the ready-to-review PR ready to review label Sep 9, 2024
Copy link
Collaborator

@vermouth22 vermouth22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we decided that the name should be standardized to "RemixAI Copilot" so that should be what it says everywhere. In any case, it should be consistent here in the toolip and in the status bar...
image

image

Also, see above screenshots... In Status Bar on open, it says the RemixAI Copilot is enabled "(enabled)" but in the tooltip it says "to use... select a .sol file" and the switch is off rather than on. So, it is confusing when status bar says "(enabled)" but the switch at top bar is in off position. And, then when you do select a .sol file you get this at top...
image

...and status bar at bottom now shows
image

@Aniket-Engg
Copy link
Collaborator Author

I think we decided that the name should be standardized to "RemixAI Copilot" so that should be what it says everywhere. In any case, it should be consistent here in the toolip and in the status bar... image

image Also, see above screenshots... In Status Bar on open, it says the RemixAI Copilot is enabled "(enabled)" but in the tooltip it says "to use... select a .sol file" and the switch is off rather than on. So, it is confusing when status bar says "(enabled)" but the switch at top bar is in off position. And, then when you do select a .sol file you get this at top... image

...and status bar at bottom now shows image

I have updated the text to RemixAI everywhere. The other behaviour where Switch and status bar is not in sync, I cannot reproduce that. Do you see it in this PR's preview link?

@vermouth22
Copy link
Collaborator

Looks good now

@Aniket-Engg Aniket-Engg merged commit 9ed694f into master Sep 10, 2024
32 checks passed
@Aniket-Engg Aniket-Engg deleted the fixRcs branch September 10, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-review PR ready to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants