Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle array of events #557

Merged
merged 3 commits into from
Nov 5, 2020
Merged

Handle array of events #557

merged 3 commits into from
Nov 5, 2020

Conversation

yann300
Copy link
Contributor

@yann300 yann300 commented Nov 5, 2020

fix #550

LianaHus
LianaHus reviewed Nov 5, 2020
View reviewed changes
libs/remix-tests/src/testRunner.ts Outdated
const testEvent = web3.eth.abi.decodeParameters(assertionEvents[eIndex].params, event.raw.data)
if (!testEvent[0]) {
const assertMethod = testEvent[2]
if(assertMethod === 'ok') { // for 'Assert.ok' method
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space after if

@yann300 yann300 merged commit 27aa909 into master Nov 5, 2020
@Aniket-Engg Aniket-Engg deleted the fixRemixTest_Event branch November 5, 2020 17:54
@adasauce
Copy link
Contributor

adasauce commented Nov 6, 2020

thanks for fixing this, will definitely clean up some of my test suite now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LianaHus LianaHus LianaHus approved these changes

@Aniket-Engg Aniket-Engg Awaiting requested review from Aniket-Engg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

testRunner crashing on test with receipt events having more than 1 of the same type
4 participants
@yann300 @adasauce @LianaHus @Aniket-Engg