Fix Debugger plugin API #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yann300
force-pushed
the
fixGetTrace
branch
2 times, most recently
from
455f6fc
to
f0794fe
Compare
LianaHus
approved these changes
Nov 11, 2020
yann300
force-pushed
the
fixGetTrace
branch
4 times, most recently
from
df9e713
to
eaa4aa0
Compare
Aniket-Engg
reviewed
Nov 12, 2020
| constructor (blockchain) { | ||
| super(profile) | ||
| constructor (blockchain, editor, offsetToLineColumnConverter) { | ||
| super(profile) |
| @@ -81,12 +84,57 @@ class DebuggerTab extends ViewPlugin { | |||
|
|
|||
| debug (hash) { | |||
| this.debugHash = hash | |||
| this.debugHashRequest++// so we can trigger a debug using the same hash 2 times in a row. that's needs to be improved | |||
There was a problem hiding this comment.
May be one space is required between ++ and //
| this.getTraceHash = hash | ||
| this.renderComponent() | ||
| if (!hash) return | ||
| return new Promise(async (resolve, reject) => { /* eslint-disable-line */ |
There was a problem hiding this comment.
Can we not directly make method async?
Aniket-Engg
approved these changes
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.