Context Menu For Plugins #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioedeveloper
requested review from
ryestew,
yann300,
LianaHus and
Aniket-Engg
yann300
reviewed
Jan 19, 2021
| @@ -34,7 +34,7 @@ var canUpload = window.File || window.FileReader || window.FileList || window.Bl | |||
| const profile = { | |||
| name: 'fileExplorers', | |||
There was a problem hiding this comment.
this new API will be public, so we should take the new very carefully. cc @bunsenstraat
yann300
reviewed
Jan 19, 2021
| */ | ||
| registerContextMenuItem (item, callback) { | ||
| if (!item.name || !callback) return console.error('menu name and callback is mandatory') | ||
| if (!item.type && !item.path && !item.extension && !item.pattern) return console.error('invalid file matching criteria provided') |
There was a problem hiding this comment.
you could also throw an error here, so it bounces back to the caller
yann300
reviewed
Jan 19, 2021
| * @param item { name: string, type?: string[], path?: string[], extension?: string[], pattern?: string[] } | ||
| * @param callback (...args) => void | ||
| */ | ||
| registerContextMenuItem (item, callback) { |
There was a problem hiding this comment.
Passing a callback might not work in the context of an iframe... (e.g I don't think that function is a valid parameter for a remix api
cc @bunsenstraat
ioedeveloper
force-pushed
the
context-menu
branch
from
a9c9a9f
to
fcb6f6a
Compare
ioedeveloper
force-pushed
the
context-menu
branch
from
fcb6f6a
to
0c7f92e
Compare
yann300
approved these changes
Jan 20, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.