Added loader for localhost #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yann300
reviewed
Mar 10, 2021
| @@ -95,6 +95,7 @@ export class RemixdHandle extends WebsocketPlugin { | |||
| label: 'Connect', | |||
| fn: () => { | |||
| try { | |||
| this.locahostProvider.event.trigger('loading') | |||
There was a problem hiding this comment.
normally event should be triggered by the class, not from an exernal one.
At least could you have a preInit() function in locahostProvider and call that one?
yann300
approved these changes
Mar 10, 2021
ioedeveloper
force-pushed
the
fix-remixd
branch
from
0694266
to
da381b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.