Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that downloadCurrentVersion.ts actually downloads the latest version #632

Open
cameel opened this issue Jun 10, 2022 · 0 comments
Open

Comments

@cameel
Copy link
Member

cameel commented Jun 10, 2022

We used to test that solcjs --version returns a version matching the one from package.json. I changed that in #626 because this is not really guaranteed - the returned version depends on the binary. So now we should also add a proper test that downloadCurrentVersion.ts actually does its job and downloads the right binary. It could be a JS test or an additional check in one of the jobs in CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Implement
Development

No branches or pull requests

1 participant