Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External contributor greeter action fails silently: jq: error (at org_members.json:0): Cannot iterate over null (null) #14393

Closed
cameel opened this issue Jul 10, 2023 · 0 comments · Fixed by #14398
Closed

External contributor greeter action fails silently: jq: error (at org_members.json:0): Cannot iterate over null (null) #14393

cameel opened this issue Jul 10, 2023 · 0 comments · Fixed by #14398
Assignees
@r0qs
Labels
bug 🐛 low effort There is not much implementation work to be done. The task is very easy or tiny. low impact Changes are not very noticeable or potential benefits are limited. must have Something we consider an essential part of Solidity 1.0.

Comments

@cameel
Copy link
Member

cameel commented Jul 10, 2023

I just noticed that our contributor greeter action did not properly label #14391 as an external PR. Looks like one of its steps fail, but the action continues and behaves as if it succeeded.

From https://github.com/ethereum/solidity/actions/runs/5504473596/jobs/10030713900:

jq: error (at org_members.json:0): Cannot iterate over null (null)
@cameel cameel added bug 🐛 low effort There is not much implementation work to be done. The task is very easy or tiny. low impact Changes are not very noticeable or potential benefits are limited. must have Something we consider an essential part of Solidity 1.0. labels Jul 10, 2023
@cameel cameel moved this from To do to In Progress in Solidity Focus Board Jul 10, 2023
@r0qs r0qs mentioned this issue Jul 10, 2023
Merged
@r0qs r0qs moved this from In Progress to Needs Review in Solidity Focus Board Jul 10, 2023
@github-project-automation github-project-automation bot moved this from Needs Review to Done in Solidity Focus Board Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@r0qs r0qs

Labels
bug 🐛 low effort There is not much implementation work to be done. The task is very easy or tiny. low impact Changes are not very noticeable or potential benefits are limited. must have Something we consider an essential part of Solidity 1.0.
Projects
Solidity Focus Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove token requirement from external contributor greeter ethereum/solidity
2 participants
@cameel @r0qs