Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multiple metadata hash verfication #1342

Merged
merged 9 commits into from
Apr 23, 2024
Merged

Support multiple metadata hash verfication #1342

merged 9 commits into from
Apr 23, 2024

Conversation

marcocastignoli
Copy link
Member

@marcocastignoli marcocastignoli commented Apr 11, 2024 •
edited
Loading

See #851

TODO

  • Fix and add lib-sourcify's test
  • Add tests for server

@kuzdogan kuzdogan self-assigned this Apr 15, 2024
kuzdogan
kuzdogan reviewed Apr 15, 2024
View reviewed changes
Copy link
Member

@kuzdogan kuzdogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now just a few comments

It's reaaaaaally difficult to read all this code. Is it only me? Maybe we need to think about reorganizing the whole thing.

packages/lib-sourcify/src/lib/CheckedContract.ts Show resolved Hide resolved
packages/lib-sourcify/src/lib/CheckedContract.ts Show resolved Hide resolved
packages/lib-sourcify/src/lib/verification.ts Show resolved Hide resolved
packages/lib-sourcify/src/lib/verification.ts Show resolved Hide resolved
@marcocastignoli marcocastignoli marked this pull request as ready for review April 16, 2024 06:16
@marcocastignoli marcocastignoli linked an issue Apr 16, 2024 that may be closed by this pull request
Unable to verify contracts with doubled metadata hash #851
Closed
kuzdogan
kuzdogan requested changes Apr 17, 2024
View reviewed changes
Copy link
Member

@kuzdogan kuzdogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parital review. I'll look more

packages/lib-sourcify/src/lib/CheckedContract.ts Outdated Show resolved Hide resolved
packages/lib-sourcify/src/lib/types.ts Outdated Show resolved Hide resolved
kuzdogan
kuzdogan approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@kuzdogan kuzdogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the tests are passing.

Just, is the "libraries" part complete? That fix we can separate from this, as I said.

@kuzdogan kuzdogan assigned marcocastignoli and unassigned kuzdogan Apr 19, 2024
@marcocastignoli
Copy link
Member Author

LGTM if the tests are passing.

Just, is the "libraries" part complete? That fix we can separate from this, as I said.

I shared what I discovered with Rim, he is also double checking if this way is the right way. He wasn't aware that you can pass libraries with the global scope "" as filepath.

@kuzdogan
Copy link
Member

@marcocastignoli meaning? What we do with this PR?

@marcocastignoli
Copy link
Member Author

@marcocastignoli meaning? What we do with this PR?

If we can wait until Monday, let's wait. Otherwise we can just merge it by commenting the new library "extractor" and skipping the related alliance test.

@marcocastignoli marcocastignoli mentioned this pull request Apr 23, 2024
Closed
@kuzdogan kuzdogan merged commit fa38b2c into staging Apr 23, 2024
6 checks passed
@kuzdogan kuzdogan deleted the support-multiple-metadata-hash-verification branch July 29, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuzdogan kuzdogan kuzdogan approved these changes

Assignees

@marcocastignoli marcocastignoli

Labels
None yet
Projects
Sourcify Public
Status: COMPLETED
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to verify contracts with doubled metadata hash
2 participants
@marcocastignoli @kuzdogan