Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shh newKeyPair first arg not optional #2507

Closed
fireblockdev opened this issue Mar 15, 2019 · 1 comment · Fixed by #2512
Closed

Shh newKeyPair first arg not optional #2507

fireblockdev opened this issue Mar 15, 2019 · 1 comment · Fixed by #2512
Labels
Bug Addressing a bug

Comments

@fireblockdev
Copy link

In the version 1.0.0-beta.48, the web3.shh.newKeyPair function needs a callback parameter even if you use the await syntax. Previously in the version 1.0.0-beta.37, it was optional as defined in the Documentation.
It could be a documentation error but it seems weird to me.
@nivida
Copy link
Contributor

nivida commented Mar 15, 2019

Thanks for creating this issue! I'll change the parameters amount here to 0.

@nivida nivida added the Bug Addressing a bug label Mar 15, 2019
@nivida nivida mentioned this issue Mar 15, 2019
Merged
12 tasks
@alcuadrado alcuadrado mentioned this issue Sep 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Addressing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Parameters amount of NewKeyPairMethod fixed. web3/web3.js
2 participants
@nivida @fireblockdev