Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subscription.js Emit 'connected' event with subscription.id #3028

Merged
merged 7 commits into from
Oct 17, 2019
Merged

subscription.js Emit 'connected' event with subscription.id #3028

merged 7 commits into from
Oct 17, 2019

Conversation

lbertenasco
Copy link
Contributor

Would something like this be possible to add?
It's useful when testing WS subscriptions successful connections.
Instead of retrying get subscription.id until it's defined.

@lbertenasco lbertenasco changed the title Update subscription.js subscription.js Emit 'connected' event with subscription.id Aug 15, 2019
@coveralls
Copy link

coveralls commented Aug 15, 2019

Coverage Status

Coverage increased (+0.006%) to 84.834% when pulling 48918ba on lbertenasco:patch-1 into ba56fc6 on ethereum:1.x.

@nivida nivida added 1.x 1.0 related issues Enhancement Includes improvements or optimizations In Progress Currently being worked on labels Aug 16, 2019
Copy link
Contributor

@nivida nivida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for proposing this PR! Could you please update the changelog file located in the root folder of this branch? and also extend the documentation?

@lbertenasco
Copy link
Contributor Author

Thanks for proposing this PR! Could you please update the changelog file located in the root folder of this branch? and also extend the documentation?

Changelog and docs updated 👍

@nivida nivida removed the In Progress Currently being worked on label Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Enhancement Includes improvements or optimizations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants