Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The transaction confirmation workflow can now be configured #3130

Merged
merged 9 commits into from
Oct 16, 2019
Merged

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Oct 15, 2019

Back-ports #1581 on the 1.x branch.

ToDo:

  • Documentation
  • Tests

…nPollingTimeout property added to the Eth, Contract, and Method class
@nivida nivida added Enhancement Includes improvements or optimizations In Progress Currently being worked on 1.x 1.0 related issues labels Oct 15, 2019
@coveralls
Copy link

coveralls commented Oct 15, 2019

Coverage Status

Coverage increased (+0.2%) to 84.829% when pulling cc17eb6 on back-port/1581 into f471981 on 1.x.

@nivida nivida requested a review from cgewecke October 15, 2019 11:44
@nivida nivida removed the In Progress Currently being worked on label Oct 15, 2019
docs/web3-eth.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@cgewecke cgewecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me. Left a suggestion for the docs...

nivida and others added 3 commits October 16, 2019 16:08
Co-Authored-By: cgewecke <christophergewecke@gmail.com>
Co-Authored-By: cgewecke <christophergewecke@gmail.com>
nachomazzara pushed a commit to nachomazzara/web3.js that referenced this pull request Jun 4, 2020
* transactionBlockTimeout, transactionConfirmationBlock, and transactionPollingTimeout property added to the Eth, Contract, and Method class

* CHANGELOG.md updated

* documentation updated

* default values added to the documentation for the newely introduced transaction fconfirmation workflow configuration properties

* test cases for the new properties added and adding of the Contract reference in the Eth module fixed

* missing space added

* Update docs/web3-eth.rst

Co-Authored-By: cgewecke <christophergewecke@gmail.com>

* Update docs/web3-eth-contract.rst

Co-Authored-By: cgewecke <christophergewecke@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Enhancement Includes improvements or optimizations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants