Contract creation on non-empty code or non-zero nonce throws an exception #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This implements ethereum/EIPs#684 |
pirapira
force-pushed
the
collision-throws
branch
from
624e547
to
677019e
Compare
pirapira
force-pushed
the
collision-throws
branch
from
677019e
to
958013d
Compare
|
Is there any more discussion on this. This is something I wondered too when reading the spec. |
livnev
approved these changes
May 13, 2019
Paper.tex
Outdated
| @@ -760,7 +760,7 @@ \section{Contract Creation}\label{ch:create}\hypertarget{endow}{} | |||
| 1 & \text{otherwise} | |||
| \end{cases} \\ | |||
| \nonumber \text{where} \\ | |||
| F &\equiv \big((\boldsymbol{\sigma}^{**} = \varnothing \ \wedge\ \mathbf{o} = \varnothing) \vee\ g^{**} < c \ \vee\ |\mathbf{o}| > 24576\big) | |||
| F \equiv &\big(\boldsymbol{\sigma}[a]_c \neq \texttt{\small KEC}\big(()\big) \ \vee\ \boldsymbol{\sigma}[a]_n \neq 0 \ \vee\ (\boldsymbol{\sigma}^{**} = \varnothing \ \wedge\ \mathbf{o} = \varnothing) \\\nonumber & \vee\ g^{**} < c \ \vee\ |\mathbf{o}| > 24576\big) | |||
There was a problem hiding this comment.
I believe this should be merged. I know that the yellow paper hasn't caught up to Constantinople yet but this would be a start.
|
@pirapira since this is now activated on mainnet, maybe the tag is no longer relavant., isn t it? |
|
For reference: geth implementation |
yperbasis
approved these changes
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a protocol change which is very hard to hit anyway. The idea is to avoid overwriting contracts even when the calculated address coincides with existing something. Here "existing something" is an account with non-zero nonce or non-empty code. This is consistent with EIP86 planned in Constantinople.
There have been some test failures happening only on the address-collision cases, but most probably the time spent there is wasted because keccak256 collisions cause far bigger problems anyway. It makes sense to make the protocol specification simpler for the address collision case.