-
Notifications
You must be signed in to change notification settings - Fork 49
Typescript migration #71
Comments
Yes, this is one of the last ones missing. @s1na not sure, did you once say that you already did some work on that? |
Agreed. Well, when we first started "The Great Migration" (:smile:) I spent an hour or so on migrating this library, but stopped soon because it depended on other libraries and they didn't have typedefs yet. So no, I don't have anything useful, we'll have to start from scratch. |
I'm working on this migration. It's a little more complicated than I expected, but not terrible. One thing that I'm wondering is if we should migrate and keep these files:
They seem super out of place to me. None of the other main libraries has anything to do with the RPC format. |
My guess is that those functions are in use by MetaMask. Let's migrate them along but create an issue to discuss their deprecation. |
Makes sense, I'll do that. |
Not having types in this library was by far the major source of bugs I had when working with the VM. I think we should consider migrating it.
The text was updated successfully, but these errors were encountered: