homestead fix

[micahriggan]

Fixing homestead bug where homestead rules are used on blocks before the fork.

closes #67

[coveralls]

Coverage increased (+0.09%) to 73.913% when pulling 4baf287 on micahriggan:patch-1 into c5dcbbc on ethereumjs:master.

[s1na]

Hi @micahriggan, thanks for the PR (and the issue).

As you also mentioned, most of the libraries have switched to ethereumjs-common for determining the active hardfork/chain, and the _homestead attribute should probably be deprecated.

I did an organization-wide search and couldn't find a remaining use for the _homestead flag (apart from some example snippets and tests which should migrate, and this line which is also setting the value, not reading) and would recommend dropping it instead of fixing its value.

What do you think @holgerd77?

[orangecstsne04]

Is there a reason to be pulling items here

[holgerd77]

@micahriggan @s1na Yes, that should likely be dropped.

[micahriggan]

So if I understand correctly, get rid of the section that sets homestead and this will be good to merge?

[micahriggan]

If #69 looks like what you'd want, feel free to close this one.

[alcuadrado]

This PR isn't necessary after #72 got merged.