This repository has been archived by the owner on Apr 6, 2020. It is now read-only.
Remove deprecated db options #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1na
approved these changes
Apr 19, 2019
alcuadrado
approved these changes
Apr 19, 2019
Merged
holgerd77
force-pushed
the
remove-deprecated-db-options
branch
from
df0da22
to
6738dad
Compare
holgerd77
force-pushed
the
remove-deprecated-db-options
branch
from
6738dad
to
baa6b68
Compare
|
Ok, rebased this after merging #105, @s1na @alcuadrado guess this needs another short review. |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we should use the occasion of a breaking release and get rid of the old DB constructor options. These have been deprecated by @vpulim along this major refactoring work #47.
This PR removed both the
opts.blockDbandopts.detailsDboptions and the simplified no-opts-constructor directly passing in the DB (which adds very little benefit on the convenience level at the cost of higher complexity and eventually not very robust code).