Skip to content
This repository has been archived by the owner on Apr 6, 2020. It is now read-only.

Makes building files unnecessary to run tests #143

Merged
merged 2 commits into from
Feb 3, 2020
Merged

Makes building files unnecessary to run tests #143

merged 2 commits into from
Feb 3, 2020

Conversation

evertonfraga
Copy link
Contributor

@evertonfraga evertonfraga commented Jan 22, 2020 •
edited
Loading

Normalizing effort based on this comment.

It uses ts-node for testing, requiring from src instead of dist.

@evertonfraga evertonfraga self-assigned this Jan 22, 2020
@evertonfraga
Copy link
Contributor Author

There's an issue with coverage reporting. I'll fix and put for review again

@holgerd77
Copy link
Member

👍

@github-actions
Copy link

github-actions bot commented Feb 3, 2020

Coverage Status

Coverage decreased (-0.2%) to 90.909% when pulling 609f955 on ts-test into e0a66d7 on master.

@evertonfraga
Copy link
Contributor Author

Up for review again.

ryanio
ryanio approved these changes Feb 3, 2020
View reviewed changes
Copy link
Contributor

@ryanio ryanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests ran fine on my local machine :)

@evertonfraga evertonfraga merged commit adcd290 into master Feb 3, 2020
@evertonfraga evertonfraga deleted the ts-test branch February 3, 2020 19:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryanio ryanio ryanio approved these changes

@holgerd77 holgerd77 Awaiting requested review from holgerd77

Assignees

@evertonfraga evertonfraga

Labels
PR state: needs review prio: P3 important
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evertonfraga @holgerd77 @ryanio