Adds definition for HF Muir Glacier

[evertonfraga]

Block numbers are still temporary.

It is only relevant for pow chains, therefore it is only present in Ropsten and Mainnet. Please let me know if should I include it elsewhere.

[evertonfraga]

• Waiting for block number be defined by EIP 2387

[evertonfraga]

Added fork blocks for mainnet and ropsten, based on https://eips.ethereum.org/EIPS/eip-2387. Ready for review.

[holgerd77]

Thanks, some minor change requests.

[evertonfraga]

Sure, and thank you for the input.

…

On Thu, Dec 5, 2019 at 6:05 PM Holger Drewes ***@***.***> wrote: ***@***.**** requested changes on this pull request. Thanks, some minor change requests. ------------------------------ In src/chains/ropsten.json <#75 (comment)> : > @@ -67,6 +67,12 @@ "block": 6485846, "consensus": "pow", "finality": null + }, + { + "name": "muirGlacier", + "block": 7117117, + "consensus": "pow", + "finality": null Re-checked the block numbers, ok. ------------------------------ In src/hardforks/muirGlacier.json <#75 (comment)> : > @@ -0,0 +1,14 @@ +{ + "name": "muirGlacier", + "comment": "HF to delay the difficulty bomb", + "eip": { + "url": "https://eips.ethereum.org/EIPS/eip-2384", + "status": "PR" This has been merged some days ago, can you change the status to "Draft" (as stated in the EIP meta data <https://github.com/ethereum/EIPs/pull/2387/files#diff-90c4019b83b11d04f0e66ddc3f5136efR7> ? ------------------------------ In tests/hardforks.ts <#75 (comment)> : > @@ -80,13 +80,17 @@ tape('[Common]: Hardfork logic', function(t: tape.Test) { msg = 'should return 2 active HFs when restricted to supported HFs' st.equal(c.activeHardforks(null, { onlySupported: true }).length, 2, msg) + c = new Common('mainnet') + msg = 'should return 10 active HFs for mainnet' + st.equal(c.activeHardforks().length, 10, msg) + Could you add one non-PoW chain to the tests here for comparison? ------------------------------ In tests/hardforks.ts <#75 (comment)> : > st.end() }) t.test('activeHardfork()', function(st: tape.Test) { let c = new Common('ropsten') - let msg = 'should return istanbul as latest active HF for Ropsten' - st.equal(c.activeHardfork(), 'istanbul', msg) + let msg = 'should return muirGlacier as latest active HF for Ropsten' + st.equal(c.activeHardfork(), 'muirGlacier', msg) Again, one non-PoW chain test here would also be good. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#75?email_source=notifications&email_token=AAALQBHYDGBUSSWFYZBIOFLQXGCLPA5CNFSM4JQWUKQKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCOFW43I#pullrequestreview-327904877>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAALQBBTULMTIIX747TYEXTQXGCLPANCNFSM4JQWUKQA> .

[holgerd77]

Hi @evertonfraga, would you find some time in the next 1-2 days to do the updates here? Think it's important that we progress here to be able to get some next HF release out before Christmas.

[evertonfraga]

Changes performed.

[holgerd77]

Cool, looks good now! 😄