Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tx: Improve EIP-2930 Tx Code Coverage #1224

Closed
holgerd77 opened this issue Apr 26, 2021 · 1 comment
Closed

Tx: Improve EIP-2930 Tx Code Coverage #1224

holgerd77 opened this issue Apr 26, 2021 · 1 comment
Labels
effort: E1 hours good first issue package: tx prio: P3 important type: tests

Comments

@holgerd77
Copy link
Member

When looking at a recent Codecov overview page for the master branch, coverage especially for the typed tx part and for BaseTransaction is not yet great respectively sufficient with coverage for baseTransaction.ts and eip2930Transaction.ts still being < 80%.

This should be improved, in a first step to get to some sufficient status quo by adding until a similar coverage as for LegacyTransaction is reached (~85%).
@hpmaxi hpmaxi mentioned this issue May 1, 2021
Merged
@holgerd77
Copy link
Member Author

This has substantially been improved, especially along the 1559 work in #1148, will close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: E1 hours good first issue package: tx prio: P3 important type: tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@holgerd77