Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tx: Throw when hash() is called on unsigned legacy txs #1890

Closed
holgerd77 opened this issue May 17, 2022 · 1 comment
Closed

Tx: Throw when hash() is called on unsigned legacy txs #1890

holgerd77 opened this issue May 17, 2022 · 1 comment
Assignees
@ScottyPoi
Labels
breaking package: tx type: refactor

Comments

@holgerd77
Copy link
Member

Part of #1717

Very small remaining breaking-release task:

Throw when hash() is called on unsigned legacy txs (so: align with behavior from typed txs), see also comment added along with #1445.

So if one is looking at e.g. the EIP-1559 Tx hash() function, the function throws if tx not signed, for the legacy tx this is not the case.

Will assign @ScottyPoi since he asked for a small EthereumJS task. 🙂
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ScottyPoi ScottyPoi

Labels
breaking package: tx type: refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@holgerd77 @ScottyPoi