Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sources for source-maps are missing in distributed packages #902

Closed
rumkin opened this issue Oct 6, 2020 · 3 comments
Closed

Sources for source-maps are missing in distributed packages #902

rumkin opened this issue Oct 6, 2020 · 3 comments

Comments

@rumkin
Copy link
Contributor

rumkin commented Oct 6, 2020

Due to current package.json configuration all packages import only dist folder. But source map files maps to src (or lib) directory. You can see it on unpkg.com at the first line: "sources":["../lib/index.ts"]. Thus source maps couldn't be loaded what makes them useless. It requires to changepackage.json#files record to include /dist and /src or /lib folders respectively into package distribution.

@rumkin
Copy link
Contributor Author

rumkin commented Oct 6, 2020

Also there is the same PR for RLP library: ethereumjs/rlp#97.

@holgerd77
Copy link
Member

Ah, just left a comment on the RLP issue linked above, of course relevant here as well. Please everyone answer there so that we have one unclustered discussion. Thanks!

@holgerd77
Copy link
Member

There is a new issue (same request) opened on this where the discussion is continued, will close here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants