Refactor tx lib #812

ryanio · 2020-07-13T20:03:19Z

This PR continues the efforts from ethereumjs/ethereumjs-tx#154, applying it to the monorepo.

TL;DR: For a full description of all the changes, please see the tx changelog.

This PR:

Refactors and simplifies the tx library to remove the use of ethereumjs-util's defineProperties (see Design problems and a proposal to fix them organization#56)
Uses types closer to their domain representation (BN, Address, etc.) instead of all Buffers
Simplifies the constructor params, and
- adds new static factory helpers fromTxData, fromRlpSerializedTx, and fromValuesArray
- only accepts Common, instead of string options for chain and hardfork

This PR also removes FakeTransaction as I found it burdensome to maintain in this refactor due to from not being stored anymore. Its only use was in block's from-rpc and can achieve the same result on the normal Transaction class with the same code there, by overriding getSenderAddress and hash, see here and the note in the readme.

Examples of updating code

tx.from
=>
tx.getSenderAddress()

tx.hash(false)
=>
tx.getMessageToSign()

new Transaction()
=>
Transaction.fromTxData({})

new Transaction(tx.rlp)
=>
Transaction.fromRlpSerializedTx(toBuffer(tx.rlp))

new Transaction(txFixtures[0].raw)
=>
Transaction.fromValuesArray(txFixtures[0].raw.map(toBuffer))

const s1 = tx.serialize().toString('hex')

const tx = new Transaction(s1)
 =>
const tx = Transaction.fromRlpSerializedTx(toBuffer('0x' + s1))

Initializing with object:

const txData = {
  gasPrice: 1000,
  gasLimit: 10000000,
  value: 42,
}
const tx = new Transaction(txData)

=>

const tx = Transaction.fromTxData(txData)

codecov · 2020-07-13T20:04:11Z

Codecov Report

Merging #812 into master will increase coverage by 0.11%.
The diff coverage is 86.63%.

Flag	Coverage Δ
#account	`92.85% <ø> (ø)`
#block	`77.08% <75.00%> (-0.18%)`	⬇️
#blockchain	`80.45% <ø> (ø)`
#common	`93.04% <ø> (ø)`
#ethash	`83.33% <ø> (ø)`
#tx	`92.94% <91.40%> (-1.04%)`	⬇️
#vm	`88.20% <76.92%> (+0.55%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

holgerd77 · 2020-07-13T21:16:09Z

Love this.

ryanio · 2020-07-13T22:35:12Z

@alcuadrado would you like me to take this one step further with your implementation example in ethereumjs/organization#56?

there are some additional ideas there not implemented in this PR yet:

domain types closer to actual representation (rather than buffer for all)
freezing the object after construction

alcuadrado · 2020-07-13T22:36:49Z

Great PR!

domain types closer to actual representation (rather than buffer for all)

I think this would be great. It would mean removing defineProperties :)

The freezing one may need more discussion. But if we are going to move to a more immutable API, I think TX is the best candidate to start with.

Also, not that freezing is not actually needed for that, but it's a good way of self imposing it.

ryanio · 2020-07-13T23:13:21Z

@s1na would you have any idea why this test is now failing with "revert" instead of "value overflow"? the test above it seems fine, so it's not immediately obvious to me, and i didn't see any "revert reason" on the exception or error object to help point toward where it might have failed 🤔

ci link

# should fail when account balance overflows (call)
ok 199 should be equal
ok 200 should be equal
# should fail when account balance overflows (create)
not ok 201 should be equal
  ---
    operator: equal
    expected: 'value overflow'
    actual:   'revert'
    at: Test.tape (/Users/ryanghods/dev/ethereumjs-vm/packages/vm/tests/api/runTx.js:112:5)
    stack: |-
      Error: should be equal
          at Test.assert [as _assert] (/Users/ryanghods/dev/ethereumjs-vm/node_modules/tape/lib/test.js:228:54)
          at Test.bound [as _assert] (/Users/ryanghods/dev/ethereumjs-vm/node_modules/tape/lib/test.js:80:32)
          at Test.equal (/Users/ryanghods/dev/ethereumjs-vm/node_modules/tape/lib/test.js:389:10)
          at Test.bound [as equal] (/Users/ryanghods/dev/ethereumjs-vm/node_modules/tape/lib/test.js:80:32)
          at Test.tape (/Users/ryanghods/dev/ethereumjs-vm/packages/vm/tests/api/runTx.js:112:5)
  ...

s1na · 2020-07-15T15:28:14Z

@ryanio hm it doesn't immediately pop into my head why a call should work as expected but a create should fail. I'd try to find where the revert is happening. You might find a lead if you print the stack trace here https://github.com/ethereumjs/ethereumjs-vm/blob/master/packages/vm/lib/evm/evm.ts#L132

lgtm-com · 2020-07-21T19:37:42Z

This pull request fixes 1 alert when merging 5963fe2 into b276092 - view on LGTM.com

fixed alerts:

1 for Unused variable, import, function or class

lgtm-com · 2020-07-21T19:45:51Z

This pull request fixes 1 alert when merging f8671fe into b276092 - view on LGTM.com

fixed alerts:

1 for Unused variable, import, function or class

packages/block/src/block.ts

ryanio · 2020-09-15T22:04:07Z

This PR should resolve the following issues: #704, #709, #710, #711, #712, #714, #829

packages/block/src/block.ts

holgerd77 · 2020-09-16T07:29:49Z

Did a little bit of debugging here on the failing blockchain tests.

When concentrating on running a single file with failing tests - e.g. with ts-node ./tests/tester --blockchain --file='bcForkBlockTest' - and injecting console.log() statements within runBlock.ts like:

try {
    result = await applyBlock.bind(this)(block, opts)
    console.log(result)
  } catch (err) {
    console.log(err)
    await state.revert()
    throw err
  }

current master gives the following output:

$ ts-node ./tests/tester --blockchain --file='bcForkBlockTest'
+--------------------------------------------------+
| VM -> BlockchainTests                            |
|                                                  |
| TestGetterArgs                                   |
| skipTests           : 54                         |
| forkConfig          : Istanbul                   |
| file                : bcForkBlockTest            |
|                                                  |
| RunnerArgs                                       |
| forkConfigVM        : istanbul                   |
| forkConfigTestSuite : Istanbul                   |
+--------------------------------------------------+

TAP version 13
# BlockchainTests
# file: bcForkBlockTest test: BlockExtraData25_Istanbul
ok 1 correct pre stateRoot
ok 2 correct genesis RLP
Error: invalid amount of extra data
    at BlockHeader.<anonymous> (/ethereumjs-vm/packages/block/src/header.ts:320:13)
    at step (/ethereumjs-vm/packages/block/dist/header.js:33:23)
    at Object.next (/ethereumjs-vm/packages/block/dist/header.js:14:53)
    at fulfilled (/ethereumjs-vm/packages/block/dist/header.js:5:58)
ok 3 Expected exception ExtraDataTooBig
# file: bcForkBlockTest test: BlockWrongResetGas_Istanbul
ok 4 correct pre stateRoot
ok 5 correct genesis RLP
Error: Invalid Signature at tx 0
    at Block.<anonymous> (/ethereumjs-vm/packages/block/src/block.ts:175:13)
    at step (/ethereumjs-vm/packages/block/dist/block.js:33:23)
    at Object.next (/ethereumjs-vm/packages/block/dist/block.js:14:53)
    at fulfilled (/ethereumjs-vm/packages/block/dist/block.js:5:58)
    at runNextTicks (internal/process/task_queues.js:59:5)
    at processImmediate (internal/timers.js:412:9)
    at process.topLevelDomainCallback (domain.js:130:23)
ok 6 Expected exception InvalidTransactionVRS
# file: bcForkBlockTest test: BlockWrongStoreClears_Istanbul
ok 7 correct pre stateRoot
ok 8 correct genesis RLP
{
  bloom: Bloom {
    bitvector: <Buffer 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ... 206 more bytes>
  },
  gasUsed: <BN: 59e7>,
  receiptRoot: <Buffer 6c 8a b3 6e c0 62 9c 97 73 4e 8a c8 23 cd d8 39 7d e6 7e fb 76 c7 be b9 83 be 73 dc d3 c7 81 41>,
  receipts: [
    {
      status: 1,
      gasUsed: <Buffer 59 e7>,
      bitvector: <Buffer 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ... 206 more bytes>,
      logs: []
    }
  ],
  results: [
    {
      gasUsed: <BN: 59e7>,
      execResult: [Object],
      bloom: [Bloom],
      amountSpent: <BN: 38306>
    }
  ]
}
ok 9 Expected exception InvalidGasUsed
# file: bcForkBlockTest test: BlockWrongStoreSetGas_Istanbul
ok 10 correct pre stateRoot
ok 11 correct genesis RLP
Error: Invalid Signature at tx 0
    at Block.<anonymous> (/ethereumjs-vm/packages/block/src/block.ts:175:13)
    at step (/ethereumjs-vm/packages/block/dist/block.js:33:23)
    at Object.next (/ethereumjs-vm/packages/block/dist/block.js:14:53)
    at fulfilled (/ethereumjs-vm/packages/block/dist/block.js:5:58)
    at runNextTicks (internal/process/task_queues.js:59:5)
    at processImmediate (internal/timers.js:412:9)
    at process.topLevelDomainCallback (domain.js:130:23)
ok 12 Expected exception InvalidTransactionVRS
# file: bcForkBlockTest test: SimpleTxCosts20000_Istanbul
ok 13 correct pre stateRoot
ok 14 correct genesis RLP
Error: Invalid Signature at tx 0
    at Block.<anonymous> (/ethereumjs-vm/packages/block/src/block.ts:175:13)
    at step (/ethereumjs-vm/packages/block/dist/block.js:33:23)
    at Object.next (/ethereumjs-vm/packages/block/dist/block.js:14:53)
    at fulfilled (/ethereumjs-vm/packages/block/dist/block.js:5:58)
    at runNextTicks (internal/process/task_queues.js:59:5)
    at processImmediate (internal/timers.js:412:9)
    at process.topLevelDomainCallback (domain.js:130:23)
ok 15 Expected exception InvalidTransactionVRS

1..15
# tests 15
# pass  15

While running the same on the tx-refactor branch gives the following:

$ ts-node ./tests/tester --blockchain --file='bcForkBlockTest'
+--------------------------------------------------+
| VM -> BlockchainTests                            |
|                                                  |
| TestGetterArgs                                   |
| skipTests           : 54                         |
| forkConfig          : Istanbul                   |
| file                : bcForkBlockTest            |
|                                                  |
| RunnerArgs                                       |
| forkConfigVM        : istanbul                   |
| forkConfigTestSuite : Istanbul                   |
+--------------------------------------------------+

TAP version 13
# BlockchainTests
# file: bcForkBlockTest test: BlockExtraData25_Istanbul
ok 1 correct pre stateRoot
ok 2 correct genesis RLP
ok 3 Expected exception ExtraDataTooBig
# file: bcForkBlockTest test: BlockWrongResetGas_Istanbul
ok 4 correct pre stateRoot
ok 5 correct genesis RLP
{
  bloom: Bloom {
    bitvector: <Buffer 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ... 206 more bytes>
  },
  gasUsed: <BN: 6596>,
  receiptRoot: <Buffer ab 6d 3e 30 83 dd ef b7 cd 46 3e 12 70 c0 7a 12 6b 51 ab 73 6a 8d 8d cc 95 a9 10 a7 3e ce 71 e9>,
  receipts: [
    {
      status: 1,
      gasUsed: <Buffer 65 96>,
      bitvector: <Buffer 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ... 206 more bytes>,
      logs: []
    }
  ],
  results: [
    {
      gasUsed: <BN: 6596>,
      execResult: [Object],
      bloom: [Bloom],
      amountSpent: <BN: 3f7dc>
    }
  ]
}
not ok 6 last block hash
  ---
    operator: equal
    expected: |-
      '8d3d0d122068250849fce79eb37f1e6838887d298d443e5b40174333b83406ec'
    actual: |-
      '78aedd8a1a7eeba4823317a7141e37bf8c5d6369e239e82ab674c33286076f05'
    at: runBlockchainTest (/ethereumjs-vm-tx-refactor/packages/vm/tests/BlockchainTestsRunner.js:139:11)
    stack: |-
      Error: last block hash
          at Test.assert [as _assert] (/ethereumjs-vm-tx-refactor/node_modules/tape/lib/test.js:228:54)
          at Test.bound [as _assert] (/ethereumjs-vm-tx-refactor/node_modules/tape/lib/test.js:80:32)
          at Test.equal (/ethereumjs-vm-tx-refactor/node_modules/tape/lib/test.js:389:10)
          at Test.bound (/ethereumjs-vm-tx-refactor/node_modules/tape/lib/test.js:80:32)
          at runBlockchainTest (/ethereumjs-vm-tx-refactor/packages/vm/tests/BlockchainTestsRunner.js:139:11)
          at /ethereumjs-vm-tx-refactor/packages/vm/tests/tester.js:112:13
          at fileCallback (/ethereumjs-vm-tx-refactor/packages/vm/tests/testLoader.js:56:11)
  ...
not ok 7 correct header block
  ---
    operator: equal
    expected: |-
      '8d3d0d122068250849fce79eb37f1e6838887d298d443e5b40174333b83406ec'
    actual: |-
      '78aedd8a1a7eeba4823317a7141e37bf8c5d6369e239e82ab674c33286076f05'
    at: runBlockchainTest (/ethereumjs-vm-tx-refactor/packages/vm/tests/BlockchainTestsRunner.js:156:11)
    stack: |-
      Error: correct header block
          at Test.assert [as _assert] (/ethereumjs-vm-tx-refactor/node_modules/tape/lib/test.js:228:54)
          at Test.bound [as _assert] (/ethereumjs-vm-tx-refactor/node_modules/tape/lib/test.js:80:32)
          at Test.equal (/ethereumjs-vm-tx-refactor/node_modules/tape/lib/test.js:389:10)
          at Test.bound (/ethereumjs-vm-tx-refactor/node_modules/tape/lib/test.js:80:32)
          at runBlockchainTest (/ethereumjs-vm-tx-refactor/packages/vm/tests/BlockchainTestsRunner.js:156:11)
          at /ethereumjs-vm-tx-refactor/packages/vm/tests/tester.js:112:13
          at fileCallback (/ethereumjs-vm-tx-refactor/packages/vm/tests/testLoader.js:56:11)
  ...
# file: bcForkBlockTest test: BlockWrongStoreClears_Istanbul
ok 8 correct pre stateRoot
ok 9 correct genesis RLP
{
  bloom: Bloom {
    bitvector: <Buffer 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ... 206 more bytes>
  },
  gasUsed: <BN: 59e7>,
  receiptRoot: <Buffer 6c 8a b3 6e c0 62 9c 97 73 4e 8a c8 23 cd d8 39 7d e6 7e fb 76 c7 be b9 83 be 73 dc d3 c7 81 41>,
  receipts: [
    {
      status: 1,
      gasUsed: <Buffer 59 e7>,
      bitvector: <Buffer 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ... 206 more bytes>,
      logs: []
    }
  ],
  results: [
    {
      gasUsed: <BN: 59e7>,
      execResult: [Object],
      bloom: [Bloom],
      amountSpent: <BN: 38306>
    }
  ]
}
not ok 10 last block hash
  ---
    operator: equal
    expected: |-
      'fe68e7d76854990d722d204f2eccc1a8c10a730deb7816cf28bbb7f3dbbcaacf'
    actual: |-
      '22f5ba1ed9ba7a09b9bc8d6f8c4a182c30e4219c775d47e2bd3f40ba5bcc260d'
    at: runBlockchainTest (/ethereumjs-vm-tx-refactor/packages/vm/tests/BlockchainTestsRunner.js:139:11)
    stack: |-
      Error: last block hash
          at Test.assert [as _assert] (/ethereumjs-vm-tx-refactor/node_modules/tape/lib/test.js:228:54)
          at Test.bound [as _assert] (/ethereumjs-vm-tx-refactor/node_modules/tape/lib/test.js:80:32)
          at Test.equal (/ethereumjs-vm-tx-refactor/node_modules/tape/lib/test.js:389:10)
          at Test.bound (/ethereumjs-vm-tx-refactor/node_modules/tape/lib/test.js:80:32)
          at runBlockchainTest (/ethereumjs-vm-tx-refactor/packages/vm/tests/BlockchainTestsRunner.js:139:11)
          at /ethereumjs-vm-tx-refactor/packages/vm/tests/tester.js:112:13
          at fileCallback (/ethereumjs-vm-tx-refactor/packages/vm/tests/testLoader.js:56:11)
  ...
not ok 11 correct header block
  ---
    operator: equal
    expected: |-
      'fe68e7d76854990d722d204f2eccc1a8c10a730deb7816cf28bbb7f3dbbcaacf'
    actual: |-
      '22f5ba1ed9ba7a09b9bc8d6f8c4a182c30e4219c775d47e2bd3f40ba5bcc260d'
    at: runBlockchainTest (/ethereumjs-vm-tx-refactor/packages/vm/tests/BlockchainTestsRunner.js:156:11)
    stack: |-
      Error: correct header block
          at Test.assert [as _assert] (/ethereumjs-vm-tx-refactor/node_modules/tape/lib/test.js:228:54)
          at Test.bound [as _assert] (/ethereumjs-vm-tx-refactor/node_modules/tape/lib/test.js:80:32)
          at Test.equal (/ethereumjs-vm-tx-refactor/node_modules/tape/lib/test.js:389:10)
          at Test.bound (/ethereumjs-vm-tx-refactor/node_modules/tape/lib/test.js:80:32)
          at runBlockchainTest (/ethereumjs-vm-tx-refactor/packages/vm/tests/BlockchainTestsRunner.js:156:11)
          at /ethereumjs-vm-tx-refactor/packages/vm/tests/tester.js:112:13
          at fileCallback (/ethereumjs-vm-tx-refactor/packages/vm/tests/testLoader.js:56:11)
  ...

// I'll cut here a bit due to getting too bulky

1..19
# tests 19
# pass  11
# fail  8

So when looking at the expected exceptions InvalidTransactionVRS along with the errors thrown on master (Error: Invalid Signature at tx 0) it seems that transactions in the new tx class are actually "fixed" in a way they shouldn't be and they should actually throw/fail?

Just an on-first-sight interpretation, it might also be the case that the fixes here are correct and our test setup is wrong, this is less likely though I would say. The work from @jochem-brouwer on #849 should help to make such kind of analysis less disambiguous by running the tests to the end (these early stops on test runs are also the reason for the differing in tests executed on the comparison from above should - I would assume - be unrelated to the root of the problem though).

jochem-brouwer · 2020-09-18T08:39:57Z

@holgerd77 FYI that injection of code is semi-equivalent to hooking up to the afterBlock event, so you don't have to edit VMs code: vm.on('afterBlock', console.log). Ah wait this doesn't work if applyBlock throws.

Just glanced over these blockchain tests, very confusing, these have to do with block tests 🤔

holgerd77 · 2020-09-21T09:02:28Z

packages/tx/src/transaction.ts

+  public readonly r?: BN
+  public readonly s?: BN
+
+  public static fromTxData(txData: TxData, common?: Common) {


Just realizing while working on a similar transition on the block library: do we want to put common here in an options dict? Think this would be more future-proof, will also introduce the like on block since there are options which needed to be passed around.

hmm I liked the simplicity of removing the need for TxOptions, but i see your point for future-proofing.

i assume we would do it for the constructor and all the factory methods?

Yes, would say so, please also put TxOptions being the last parameter for the constructor for consistency (unless you have got an explicit reason not to).

Yeah, sorry for un-simplify here a bit, but I think this is quite a realistic scenario that we want to add here at some point and it would be a bit a pity if this would be blocked by not have this prepared.

holgerd77

LGTM

Some last comments for the next cosmetic finalization round. 😄

Will merge.

holgerd77 · 2020-09-21T21:10:47Z

packages/vm/lib/runBlockchain.ts

@@ -29,6 +29,7 @@ export default async function runBlockchain(this: VM, blockchain?: Blockchain) {
    // run block, update head if valid
    try {
      await this.runBlock({ block, root: parentState })
+      console.log()


boo, i'll clean this up :)

holgerd77 · 2020-09-21T21:20:26Z

packages/tx/src/transaction.ts

+  public readonly r?: BN
+  public readonly s?: BN
+
+  public static fromTxData(txData: TxData, common?: Common) {


Yes, would say so, please also put TxOptions being the last parameter for the constructor for consistency (unless you have got an explicit reason not to).

Yeah, sorry for un-simplify here a bit, but I think this is quite a realistic scenario that we want to add here at some point and it would be a bit a pity if this would be blocked by not have this prepared.

holgerd77 · 2020-09-21T21:29:20Z

packages/tx/src/transaction.ts

  }

  /**
-   * sign a transaction with a given private key
+   * Sign a transaction with a given private key
   * @param privateKey - Must be 32 bytes in length
   */
  sign(privateKey: Buffer) {


I think we should point this out more clearly in the code docs that this only gives a signed transaction if assigned to a new variable, otherwise this is too dangerous that people assume their transaction to be signed when just using tx.sign() (and not further thinking about immutability, which is in fact rather likely than unlikely I would assume).

holgerd77 · 2020-09-21T21:32:25Z

🎉

* block -> refactor: reworked header class with static factory instantiation helpers, removed defineProperties usage, fixed header tests * block -> refactoring: added new static factory helpers to block class * block -> refactor: fix build errors, remove unused imports, unpad number-value buffers in header * block -> rename Header to BlockHeader * block/tx -> fix block tests * block -> enforce BNs on fields which are interpreted as numbers * block -> edge case in toBN block -> fix tests, fix util * ethash -> make ethash compatible with block * have validateTransactions return a string[] (#812 (comment)) * let => const * set default param to resolve js runtime check * continue refactoring and simplifying methods freeze both block and header objects use Address for coinbase * api updates * continuing work * inline buffer validations. add checks for extraData, mixHash and nonce * various fixups * continuing various work * continuing work and refactoring added Block.genesis() and BlockHeader.genesis() alias update vm * re-add timestamp to genesis (for rinkeby) * last fixups * update readme, benchmarks * update vm readme, simplify validate * fix timestamp validation * use native eq * make blockchain optional in block.validate() move genTxTrie() inside validateTransactionsTrie() * fixups * remove BLOCK_difficulty_GivenAsList from skip list (#883 (comment)) Co-authored-by: Jochem Brouwer <jochembrouwer96@gmail.com> Co-authored-by: Ryan Ghods <ryan@ryanio.com>

ryanio added type: refactor package: tx labels Jul 13, 2020

This comment has been minimized.

Sign in to view

ryanio force-pushed the tx-refactor branch 2 times, most recently from 0f6cf99 to c1a5d06 Compare July 13, 2020 22:34

ryanio added the PR state: WIP label Jul 14, 2020

ryanio force-pushed the tx-refactor branch from c1a5d06 to 05221b4 Compare July 17, 2020 22:33

This comment has been minimized.

Sign in to view

ryanio force-pushed the tx-refactor branch from 05221b4 to 10895cd Compare July 17, 2020 22:47

This comment has been minimized.

Sign in to view

ryanio force-pushed the tx-refactor branch from 10895cd to 460056f Compare July 20, 2020 21:04

This comment has been minimized.

Sign in to view

ryanio force-pushed the tx-refactor branch from 460056f to 5963fe2 Compare July 21, 2020 19:32

Refactor tx lib

f8671fe

ryanio force-pushed the tx-refactor branch from 5963fe2 to f8671fe Compare July 21, 2020 19:40

ryanio added PR state: needs review and removed PR state: WIP labels Jul 21, 2020

ryanio requested review from evertonfraga and alcuadrado July 21, 2020 19:57

alcuadrado reviewed Jul 21, 2020

View reviewed changes

packages/block/src/block.ts Outdated Show resolved Hide resolved

alcuadrado reviewed Jul 21, 2020

View reviewed changes

packages/block/src/block.ts Outdated Show resolved Hide resolved

alcuadrado reviewed Jul 21, 2020

View reviewed changes

packages/block/src/block.ts Outdated Show resolved Hide resolved

ryanio mentioned this pull request Sep 15, 2020

Parsing raw transactions is complicated in 2.x #708

Closed

holgerd77 reviewed Sep 16, 2020

View reviewed changes

packages/block/src/block.ts Outdated Show resolved Hide resolved

ryanio added 2 commits September 17, 2020 10:08

fixups

e9cf49c

Merge branch 'master' into tx-refactor

bc3cc3f

ryanio force-pushed the tx-refactor branch from f4c99c5 to bc0e0a8 Compare September 17, 2020 17:24

common is already setHardforkByBlockNumber in header constructor

349c8eb

ryanio force-pushed the tx-refactor branch from bc0e0a8 to 349c8eb Compare September 18, 2020 01:04

holgerd77 reviewed Sep 21, 2020

View reviewed changes

holgerd77 mentioned this pull request Sep 21, 2020

Block library refactoring #883

Merged

Merge branch 'master' into tx-refactor

73e4a10

evertonfraga mentioned this pull request Sep 21, 2020

Updates to ethereumjs-config v2.0.0 (old) #886

Closed

18 tasks

ryanio added 2 commits September 21, 2020 13:38

fixups

d5fed0a

Merge branch 'master' into tx-refactor

4491218

ryanio added PR state: merge ready and removed PR state: needs review labels Sep 21, 2020

holgerd77 approved these changes Sep 21, 2020

View reviewed changes

holgerd77 merged commit b1429b9 into master Sep 21, 2020

holgerd77 deleted the tx-refactor branch September 21, 2020 21:32

ryanio added a commit that referenced this pull request Oct 8, 2020

have validateTransactions return a string[] (#812 (comment))

5351fb8

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor tx lib #812

Refactor tx lib #812

ryanio commented Jul 13, 2020 •

edited

Loading

codecov bot commented Jul 13, 2020 •

edited

Loading

This comment has been minimized.

holgerd77 commented Jul 13, 2020

ryanio commented Jul 13, 2020

alcuadrado commented Jul 13, 2020 •

edited

Loading

ryanio commented Jul 13, 2020

s1na commented Jul 15, 2020

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

lgtm-com bot commented Jul 21, 2020

lgtm-com bot commented Jul 21, 2020

ryanio commented Sep 15, 2020

holgerd77 commented Sep 16, 2020 •

edited

Loading

jochem-brouwer commented Sep 18, 2020 •

edited

Loading

holgerd77 Sep 21, 2020

ryanio Sep 21, 2020

holgerd77 Sep 21, 2020

holgerd77 left a comment

holgerd77 Sep 21, 2020

ryanio Sep 22, 2020

holgerd77 Sep 21, 2020

holgerd77 Sep 21, 2020

holgerd77 commented Sep 21, 2020

Refactor tx lib #812

Refactor tx lib #812

Conversation

ryanio commented Jul 13, 2020 • edited Loading

Examples of updating code

codecov bot commented Jul 13, 2020 • edited Loading

Codecov Report

This comment has been minimized.

holgerd77 commented Jul 13, 2020

ryanio commented Jul 13, 2020

alcuadrado commented Jul 13, 2020 • edited Loading

ryanio commented Jul 13, 2020

s1na commented Jul 15, 2020

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

lgtm-com bot commented Jul 21, 2020

lgtm-com bot commented Jul 21, 2020

ryanio commented Sep 15, 2020

holgerd77 commented Sep 16, 2020 • edited Loading

jochem-brouwer commented Sep 18, 2020 • edited Loading

holgerd77 Sep 21, 2020

Choose a reason for hiding this comment

ryanio Sep 21, 2020

Choose a reason for hiding this comment

holgerd77 Sep 21, 2020

Choose a reason for hiding this comment

holgerd77 left a comment

Choose a reason for hiding this comment

holgerd77 Sep 21, 2020

Choose a reason for hiding this comment

ryanio Sep 22, 2020

Choose a reason for hiding this comment

holgerd77 Sep 21, 2020

Choose a reason for hiding this comment

holgerd77 Sep 21, 2020

Choose a reason for hiding this comment

holgerd77 commented Sep 21, 2020

ryanio commented Jul 13, 2020 •

edited

Loading

codecov bot commented Jul 13, 2020 •

edited

Loading

alcuadrado commented Jul 13, 2020 •

edited

Loading

holgerd77 commented Sep 16, 2020 •

edited

Loading

jochem-brouwer commented Sep 18, 2020 •

edited

Loading