New freeze option to deactivate block, tx freeze / Fix block options passing #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ck options passing bug
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
I was just working on some extra tests here to verify that these |
block: block/header: add option carry-over test tx: add option carry-over test
cgewecke
approved these changes
Nov 6, 2020
| @@ -43,6 +43,17 @@ export interface BlockOptions { | |||
| * difficulty takes precedence over a provided static `difficulty` value. | |||
| */ | |||
| calcDifficultyFromHeader?: BlockHeader | |||
| /** | |||
| * A block object by default gets frozen along initialization. This gives you | |||
There was a problem hiding this comment.
Suggested change
| * A block object by default gets frozen along initialization. This gives you | |
| A block object by default gets frozen during initialization. This gives you |
Just a tiny idiomatic change here...
This comment block is really helpful...makes the rationale for freezing very clear.
There was a problem hiding this comment.
Will leave this out since I don't want to dismiss the approval, hope that's ok.
cgewecke
reviewed
Nov 6, 2020
| @@ -70,7 +70,7 @@ export class Block { | |||
| uncleHeaders.push(BlockHeader.fromValuesArray(uncleHeaderData, opts)) | |||
| } | |||
|
|
|||
| return new Block(header, transactions, uncleHeaders) | |||
| return new Block(header, transactions, uncleHeaders, opts) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #940