Implement the personal api #262
Conversation
|
This is enough to work with browser-solidity and soltest (of solidity). |
axic
force-pushed
the
personal-api
branch
2 times, most recently
from
636454c
to
3cc59d7
Compare
|
Any chance I can get some added tests for these methods? |
| }); | ||
| }); | ||
|
|
||
| describe("personal_unlockAccount", function() { |
There was a problem hiding this comment.
This test could use more code that ensures the locked state of this account actually changed, vs. simply checking the boolean (i.e., make a transaction on the locked account, assert it doesn't work, unlock, make a transaction on the now unlocked account, assert it worked). Would be great if you could add this, but I'll do so if I can get to it.
There was a problem hiding this comment.
@tcoulter I will not have time for a week at least, so please if you can, add those tests 😉
|
@axic Sorry for such the long wait on this. I've added it to the |
Based on https://github.com/ethereum/go-ethereum/wiki/Management-APIs#personal
Fixes #215 and #236.