From 3c1bad2fb7ad4a6ff90ff11f3e382fd18e41c800 Mon Sep 17 00:00:00 2001 From: Richard Moore Date: Tue, 6 Jun 2023 19:24:19 -0400 Subject: [PATCH] Fix stray promises when a node returns invalid results (#4118). --- src.ts/providers/provider-jsonrpc.ts | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src.ts/providers/provider-jsonrpc.ts b/src.ts/providers/provider-jsonrpc.ts index cf9732a34a..c3828731bf 100644 --- a/src.ts/providers/provider-jsonrpc.ts +++ b/src.ts/providers/provider-jsonrpc.ts @@ -505,7 +505,12 @@ export abstract class JsonRpcApiProvider extends AbstractProvider { // No result; the node failed us in unexpected ways if (resp == null) { - return reject(makeError("no response from server", "BAD_DATA", { value: result, info: { payload } })); + const error = makeError("missing response for request", "BAD_DATA", { + value: result, info: { payload } + }); + this.emit("error", error); + reject(error); + continue; } // The response is an error