Can't recognize type in deploying library contract using ethers

[Aliceonly]

Ethers Version

6.11.1

Search Terms

No response

Describe the Problem

when I use interface in library contract , it cuz ethers warning while deploying：

[Warning] Invalid Fragment {"inputs":[{"internalType":"contract IVault","name":"vault","type":"IVault"},{"internalType":"uint256","name":"price","type":"uint256"}],"name":"toBasePrice","outputs":[{"internalType":"uint256","name":"","type":"uint256"}],"stateMutability":"view","type":"function"}: invalid type (argument="type", value="IVault", code=INVALID_ARGUMENT, version=6.11.1).

I also noticed that any struct, interface, enum as func params in library contract would lead to this warning when deploying using ethers

Code Snippet

import "contracts/interfaces/IVault.sol";

library Fee {
    function toBasePrice(
        IVault vault,
        uint256 price
    ) external view returns (uint256) {
        uint256 _decimals = vault.decimals();
        return (price / 10 ** _decimals);
    }
}

### Contract ABI

_No response_

### Errors

_No response_

### Environment

Hardhat

### Environment (Other)

_No response_

[ricmoo]

There is no Solidity type called an IVault. I’m guessing it is an address? Or possibly a struct?

[Aliceonly]

There is no Solidity type called an IVault. I’m guessing it is an address? Or possibly a struct?

It's an interface contract used as type.

Customized struct in lib contract also leads this warning

[ricmoo]

Can you include what you are doing that gives that error when you use the struct?

Keep in mind Ethers needs to know what the “shape” of the struct looks like in order to encode and decode data into the format that the contract is expecting.

I need more background to help. :)

(moving to discussions though, as this isn’t a bug in Ethers)

[Aliceonly]

For example, using Enum in library contract:

library Order {
    enum OrderType {
        MARKET,
        LIMIT,
        TP,
        SL
    }
struct IncreaseOrder {
        ...
        OrderType orderType;
}
function isValidOrder(
        IncreaseOrder memory request // as param in func
}

When deploy Order lib , leads warning:

[Warning] Invalid Fragment {"inputs":[{"components":[...(here are function params deconstructed)]}: invalid type (argument="type", value="Order.OrderType", code=INVALID_ARGUMENT, version=6.11.1)

[xiaoyu1998]

is there any progress of this issue? I have met same problem, when i use a contract as type to a function input, but not all functions warning this issue in this library, Cuz other functions were compiled this contract type to type address.

[Aliceonly]

nope

[xiaoyu1998]

[Warning] Invalid Fragment {"inputs":[{"internalType":"contract DataStore","name":"dataStore","type":"DataStore"},{"internalType":"address","name":"underlyingAsset","type":"address"}],"name":"get","outputs":[{"internalType":"address","name":"","type":"address"}],"stateMutability":"view","type":"function"}: invalid type (argument="type", value="DataStore", code=INVALID_ARGUMENT, version=6.11.1)

[xiaoyu1998]

I am tracking this issue, it was assert by ethers/lib.commonjs/abi/fragments.js/verifyBasicType
it need '/^(address|bool|bytes([0-9])|string|u?int([0-9]))$/' but get DataStore

[xiaoyu1998]

OracleStoreUtils.json

const oracle = new ethers.Interface(OracleStoreUtils.abi);

This line will get the warning, I have tested in mac and ubuntu

[Aliceonly]

seems ethers doesn't parse abi properly

[ricmoo]

Can you include a minimum viable example abi that fails?

[ricmoo]

Looking at the above error, this is an issue with Library ABIs, which seem to use types which need resolution. I believe you need to either use the compiler/linker output, or change the type from IValue (and such) to address.

[xiaoyu1998]

OracleStoreUtils.json is the output from solidity 0.8.20 compiler which was build in hardhat 2.22.2. I have edited it to a minimum sample have this fail.

[xiaoyu1998]

the same abi in ethers.js V5.7.2 do NOT have this warning

const oracle = new ethers.utils.Interface(OracleStoreUtils.abi);

[gavfu]

I got similar warnings after upgrading from ethers V5 to V6, which is a bit annoying. Hopefully it will be fixed in future release.

[lucastDC]

I met this problem with "ethers": "^6.13.2", any solution for this?