Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong EventFilter typescript typings #1434

Closed
Siegrift opened this issue Apr 6, 2021 · 2 comments
Closed

Wrong EventFilter typescript typings #1434

Siegrift opened this issue Apr 6, 2021 · 2 comments
Labels
enhancement New feature or improvement. fixed/complete This Bug is fixed or Enhancement is complete and published. minor-bump Planned for the next minor version bump.

Comments

@Siegrift
Copy link

Siegrift commented Apr 6, 2021

Hello,

according to EventFilter documentation it should be possible and valid to have filter topics like this:

    topics: [
      ethers.utils.id('WithdrawalFulfilled(bytes32,uint256,bytes32,address,address,uint256)'),
      // TODO: what about these?
      null,
      null,
      withdrawalRequestId,
    ],

however, the current typings only let you specify null for the root of the topics.
@deanshelton913 deanshelton913 mentioned this issue Apr 23, 2021
Closed
@ricmoo ricmoo added enhancement New feature or improvement. minor-bump Planned for the next minor version bump. on-deck This Enhancement or Bug is currently being worked on. labels Apr 23, 2021
@ricmoo
Copy link
Member

ricmoo commented May 20, 2021

This should be fixed in 5.2.0.

Please try it out and let me know if there are still any issues. Thanks! :)

@ricmoo ricmoo added fixed/complete This Bug is fixed or Enhancement is complete and published. and removed on-deck This Enhancement or Bug is currently being worked on. labels May 20, 2021
@ricmoo ricmoo closed this as completed May 30, 2021
@Siegrift
Copy link
Author

Oh, sorry I totally missed your reply.

Yeah it works - thanks for fixing!

@the-emerald the-emerald mentioned this issue Jul 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or improvement. fixed/complete This Bug is fixed or Enhancement is complete and published. minor-bump Planned for the next minor version bump.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ricmoo @Siegrift