Re-ordered Export Types #3755
Closed
Re-ordered Export Types #3755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That explains the issue with #3703. Thanks! Unfortunately this isn't as simple as modifying the I'll add a fix to that in the necessary scripts. |
|
Awesome! Let me know what I can do to help! If you'd like any! 🙂 |
ricmoo
added
on-deck
ricmoo
added a commit
that referenced
this pull request
Feb 19, 2023
|
Fixed in v6.0.5. Thanks! :) |
ricmoo
added
fixed/complete
Woodpile37
pushed a commit
to Woodpile37/ethers.js
that referenced
this pull request
Jan 14, 2024
Woodpile37
pushed a commit
to Woodpile37/ethers.js
that referenced
this pull request
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-ordered Export Types in packages to comply with TypeScripts recommendation when deploying types with packages.
Links for reference:
Detected running a lint:
https://publint.dev/ethers@6.0.2
Lint error definition:
https://publint.dev/rules#exports_types_should_be_first
TypeScript Docs:
https://www.typescriptlang.org/docs/handbook/esm-node.html#packagejson-exports-imports-and-self-referencing
Additional notes:
These are non-breaking changes 🙂