Skip to content
This repository has been archived by the owner on Aug 2, 2021. It is now read-only.

Update peer suggestion engine after kademlia depth redefinition #1063

Closed
nolash opened this issue Dec 17, 2018 · 0 comments · Fixed by ethereum/go-ethereum#18404
Closed

Update peer suggestion engine after kademlia depth redefinition #1063

nolash opened this issue Dec 17, 2018 · 0 comments · Fixed by ethereum/go-ethereum#18404
Assignees

Comments

@nolash
Copy link
Contributor

nolash commented Dec 17, 2018

After the redefinition of kademlia depth, the values for updated discovery radius that the kademlia gives to the hive may be invalid. Some clues and thoughts:

  • High-level tests suggest that noded tend to connect to all peers they can find.
  • The test TestSuggestPeersFindPeers() is failing, but in apparently nonsensical conditions.
  • The return value(s) of kademlia.SuggestPeer() are ambigious.
  • The term "depth" seems to mean different things whether you talk about routing or discovery.
@nolash nolash self-assigned this Dec 17, 2018
@nolash nolash changed the title Update peer suggestion after kademlia depth redefinition Update peer suggestion engine after kademlia depth redefinition Dec 17, 2018
@zelig zelig assigned zelig and unassigned nolash Jan 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants